Closed
Bug 955338
Opened 10 years ago
Closed 10 years ago
Change behaviour around unhandled CTCP messages
Categories
(Chat Core :: IRC, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: benediktp, Assigned: aleth)
References
(Blocks 1 open bug)
Details
(Whiteboard: [1.4-wanted])
Attachments
(2 files)
1.21 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
850 bytes,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1902 at 2013-03-21 12:25:00 UTC *** When we could not handle a CTCP message, an ERRMSG reply [1] should be sent, a warning logged and the message no longer be shown to the user [3]. [1] http://log.bezut.info/instantbird/130321/#m138 [2] http://log.bezut.info/instantbird/130321/#m148 [3] http://log.bezut.info/instantbird/130321/#m140
Comment 1•10 years ago
|
||
*** Original post on bio 1902 at 2013-03-21 12:28:00 UTC *** Note that this can block adding more CTCP response handlers (as it would give a bad UX for those without the extension, etc.)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → aleth
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1902 as attmnt 2292 at 2013-03-21 17:38:00 UTC *** This throws a warning and sends an ERRMSG. The ERRMSG spec [1] suggest sending 'a text explaining what the problem is, like "unknown query" or "failed decrypting text"'. I used a simple "Unhandled CTCP command" here as if a CTCP command handler encounters a problem, it should respond with an ERRMSG itself. [1] http://www.irchelp.org/irchelp/rfc/ctcpspec.html
Attachment #8354057 -
Flags: review?(clokep)
Comment 3•10 years ago
|
||
Comment on attachment 8354057 [details] [diff] [review] Patch *** Original change on bio 1902 attmnt 2292 at 2013-03-21 17:57:42 UTC *** This looks fine to me. I don't have "Unhandled CTCP command", but I have no better string...
Attachment #8354057 -
Flags: review?(clokep) → review+
Assignee | ||
Updated•10 years ago
|
Whiteboard: [1.4-wanted] → [1.4-wanted][checkin-needed]
Comment 4•10 years ago
|
||
*** Original post on bio 1902 at 2013-03-21 22:33:32 UTC *** Checked in as http://hg.instantbird.org/instantbird/rev/e29aff2c3db3 Thanks for fixing this so quickly! :)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.4-wanted][checkin-needed] → [1.4-wanted]
Assignee | ||
Comment 5•10 years ago
|
||
*** Original post on bio 1902 as attmnt 2298 at 2013-03-23 14:56:00 UTC *** Patch to fix the bug in the target the ERRMSG is sent to (it should go to whoever sent the CTCP message, not to its target).
Attachment #8354063 -
Flags: review?(clokep)
Comment 6•10 years ago
|
||
Comment on attachment 8354063 [details] [diff] [review] Patch to fix bug in ERRMSG target *** Original change on bio 1902 attmnt 2298 at 2013-03-23 17:51:44 UTC *** Sorry I missed this the first time!
Attachment #8354063 -
Flags: review?(clokep) → review+
Updated•10 years ago
|
Whiteboard: [1.4-wanted] → [1.4-wanted][checkin-needed]
Comment 7•10 years ago
|
||
*** Original post on bio 1902 at 2013-03-24 17:46:38 UTC *** http://hg.instantbird.org/instantbird/rev/9461ba5e15ca
Whiteboard: [1.4-wanted][checkin-needed] → [1.4-wanted]
You need to log in
before you can comment on or make changes to this bug.
Description
•