955386 - Reference to undefined property this._account.maxMessageLength

Status: RESOLVED FIXED

(Chat Core :: Twitter, defect)

Description

[aleth [:aleth]]

*** Original post on bio 1948 at 2013-04-24 17:54:00 UTC ***

ReferenceError: reference to undefined property this._account.maxMessageLength Source file:.../twitter.js Line: 167

Comment 1

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 1948 as attmnt 2408 at 2013-04-24 21:16:00 UTC ***

Drive-by thought: Do we *really* want to throw an error (NS_ERROR_ILLEGAL_VALUE) just because someone presses return on a message that is too long?

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8354175 [details] [diff] [review]
Patch

*** Original change on bio 1948 attmnt 2408 at 2013-04-24 22:49:04 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 3

[Patrick Cloke [:clokep]]

*** Original post on bio 1948 at 2013-04-28 03:16:30 UTC ***

http://hg.instantbird.org/instantbird/rev/b624f485b830

Thanks!

Comment 4

[Florian Quèze [:florian]]

*** Original post on bio 1948 at 2013-04-28 09:10:22 UTC ***

(In reply to comment #1)

> Drive-by thought: Do we *really* want to throw an error
> (NS_ERROR_ILLEGAL_VALUE) just because someone presses return on a message that
> is too long?

Is there an undesirable side effect?

Comment 5

[aleth [:aleth]]

*** Original post on bio 1948 at 2013-04-29 09:19:05 UTC ***

(In reply to comment #3)
> > Drive-by thought: Do we *really* want to throw an error
> > (NS_ERROR_ILLEGAL_VALUE) just because someone presses return on a message that
> > is too long?
> 
> Is there an undesirable side effect?

Only the noise in the error console ;)