Closed
Bug 955388
Opened 10 years ago
Closed 10 years ago
Completing "/me" shows the list of suggestions as action inside a system message
Categories
(Instantbird Graveyard :: Other, defect)
Instantbird Graveyard
Other
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: benediktp, Assigned: aleth)
Details
Attachments
(3 files)
8.73 KB,
image/png
|
Details | |
1.04 KB,
patch
|
benediktp
:
review-
|
Details | Diff | Splinter Review |
1.30 KB,
patch
|
benediktp
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 1950 at 2013-04-26 19:11:00 UTC *** *** Due to BzAPI limitations, the initial description is in comment 1 ***
Reporter | ||
Comment 1•10 years ago
|
||
*** Original post on bio 1950 as attmnt 2414 at 2013-04-26 19:11:00 UTC *** Completing "/me" shows the list of suggestions as action inside a system message. See screenshot [1] for an example (2nd system message). It's a customized version of Bubbles but there's a regular system message too (1st system message) for comparison.
Assignee | ||
Comment 2•10 years ago
|
||
*** Original post on bio 1950 as attmnt 2418 at 2013-04-27 17:54:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354185 -
Flags: review?(benediktp)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 1950 as attmnt 2419 at 2013-04-27 17:58:00 UTC *** Alternative patch, no functional changes, makes the surrounding code a bit easier to read imho.
Attachment #8354186 -
Flags: review?(benediktp)
Reporter | ||
Comment 4•10 years ago
|
||
Comment on attachment 8354185 [details] [diff] [review] Patch *** Original change on bio 1950 attmnt 2418 at 2013-04-27 19:06:24 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354185 -
Flags: review?(benediktp) → review-
Reporter | ||
Comment 5•10 years ago
|
||
Comment on attachment 8354186 [details] [diff] [review] Alternative patch *** Original change on bio 1950 attmnt 2419 at 2013-04-27 19:13:44 UTC *** (In reply to comment #2) > Created attachment 8354186 [details] [diff] [review] (bio-attmnt 2419) [details] > Alternative patch > > Alternative patch, no functional changes, makes the surrounding code a bit > easier to read imho. The "if { } else { }" is indeed easier to read this way. Thanks for fixing!
Attachment #8354186 -
Flags: review?(benediktp) → review+
Reporter | ||
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Comment 6•10 years ago
|
||
*** Original post on bio 1950 at 2013-05-21 19:58:38 UTC *** http://hg.instantbird.org/instantbird/rev/cbc1b681d1c5 Thanks!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•