Closed Bug 955443 Opened 10 years ago Closed 10 years ago

Remove last vestiges of WINCE support

Categories

(Chat Core :: General, defect)

x86
Other
defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: clokep, Assigned: clokep)

References

Details

Attachments

(1 file, 2 obsolete files)

*** Original post on bio 2007 at 2013-06-17 10:55:00 UTC ***

+++ This bug was initially created as a clone of Bug #954994 (bio 1563) +++

We removed support for WINCE in bug 954994 (bio 1563), but it's still in a few of our Makefiles/configure scripts.

http://lxr.instantbird.org/instantbird/search?string=wince
Depends on: 954994
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 2007 as attmnt 2916 at 2013-10-01 00:10:00 UTC ***

- This does not touch anything inside of purple/libraries.
- I could not find a matching %endif inside of accounts.css.
- This does not touch configure.in, as that's pseudo-synced to c-c.
Attachment #8354686 - Flags: review?(florian)
Comment on attachment 8354686 [details] [diff] [review]
Patch

*** Original change on bio 2007 attmnt 2916 at 2013-10-03 16:11:16 UTC ***

The changes here look good, but please cleanup purple/libraries/glib/Makefile.in too.

I think the WinCE stuff in purple/libraries/xml2/ was part of the upstream library.

It's a bit strange to have OS2 stuff in instantbird/app/Makefile.in
Thunderbird doesn't seem to have the same in mail/app/Makefile.in, so it's likely something we can cleanup too (but that sounds like something for a different bug).
Attachment #8354686 - Flags: review?(florian) → review-
Attached patch Patch v2 (obsolete) — Splinter Review
*** Original post on bio 2007 as attmnt 2923 at 2013-10-03 20:56:00 UTC ***

This also kills WINCE in the glib Makefile.in.
Attachment #8354694 - Flags: review?(florian)
Comment on attachment 8354686 [details] [diff] [review]
Patch

*** Original change on bio 2007 attmnt 2916 at 2013-10-03 20:56:04 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354686 - Attachment is obsolete: true
Attached patch Patch v2Splinter Review
*** Original post on bio 2007 as attmnt 2924 at 2013-10-03 21:01:00 UTC ***

The real second version of this. The last attachment was a messed up patch.
Attachment #8354695 - Flags: review?(florian)
Comment on attachment 8354694 [details] [diff] [review]
Patch v2

*** Original change on bio 2007 attmnt 2923 at 2013-10-03 21:01:56 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354694 - Attachment is obsolete: true
Attachment #8354694 - Flags: review?(florian)
Comment on attachment 8354695 [details] [diff] [review]
Patch v2

*** Original change on bio 2007 attmnt 2924 at 2013-10-03 21:09:31 UTC ***

Thanks!
Attachment #8354695 - Flags: review?(florian) → review+
*** Original post on bio 2007 at 2013-10-03 22:48:48 UTC ***

http://hg.instantbird.org/instantbird/rev/4b75bba01d04
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.