955448 - Change behavior of /time command

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[Benedikt Pfeifer]

*** Original post on bio 2011 at 2013-06-21 22:02:00 UTC ***

The response to the /time IRC command isn't handled as it seems:

Timestamp: 21.06.2013 23:57:58
Warning: Unhandled IRC message: :gravel.mozilla.org 391 Mic gravel.mozilla.org :Friday June 21 2013 -- 14:57 -07:00
Source File: resource://gre/components/irc.js
Line: 684
Source Code: prpl-irc

Comment 1

[Benedikt Pfeifer]

*** Original post on bio 2011 at 2013-06-21 23:59:40 UTC ***

I was under the mistaken impression that the /time command was returning the local time of a user. It's actually returning the local time of the IRC server (which is most likely completely useless information?).

"/time <nick>" should request the time via CTCP ("/ctcp <nick> TIME") instead and it was suggested [1] that with no parameter it could still show the server time.

[1] http://log.bezut.info/instantbird/130621#m868

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Patch

Simple patch that fixes /time to send to the server OR to a person.

Displays the results appropriately.

Comment 3

[aleth [:aleth]]

Comment on attachment 8561065 [details] [diff] [review]
Patch

Review of attachment 8561065 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

::: chat/protocols/irc/ircBase.jsm
@@ +1081,5 @@
>      "391": function(aMessage) { // RPL_TIME
>        // <server> :<string showing server's local time>
> +
> +      let msg = _("ctcp.time", aMessage.params[1], aMessage.params[2]);
> +      // Show the date returned from the server, not that this doesn't use

typo: s/not/note

Comment 4

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/35038c7f1bf6