Closed Bug 955460 Opened 10 years ago Closed 10 years ago

Services.cmd.unregisterCommand is broken

Categories

(Chat Core :: General, defect)

x86
Other
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nhnt11, Assigned: aleth)

Details

Attachments

(2 files)

*** Original post on bio 2023 at 2013-06-28 13:25:00 UTC ***

After doing Services.cmd.unregisterCommand(), the command remains available to use.
*** Original post on bio 2023 at 2013-06-28 13:42:06 UTC ***

Please attach your STR.
*** Original post on bio 2023 as attmnt 2530 at 2013-06-28 13:50:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attached patch PatchSplinter Review
*** Original post on bio 2023 as attmnt 2531 at 2013-06-28 15:32:00 UTC ***

Please test.
Attachment #8354299 - Flags: review?(nhnt11)
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment on attachment 8354299 [details] [diff] [review]
Patch

*** Original change on bio 2023 attmnt 2531 at 2013-06-28 15:37:07 UTC ***

r=me assuming tests show that this fixes the bug.
Attachment #8354299 - Flags: review?(nhnt11) → review+
*** Original post on bio 2023 at 2013-06-28 15:41:25 UTC ***

Comment on attachment 8354299 [details] [diff] [review] (bio-attmnt 2531)
Patch

Tested this, works fine. Thanks!
Whiteboard: [checkin-needed]
*** Original post on bio 2023 at 2013-06-29 12:22:18 UTC ***

http://hg.instantbird.org/instantbird/rev/318b01b2edfb

Thanks for fixing this!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.