Closed
Bug 955460
Opened 10 years ago
Closed 10 years ago
Services.cmd.unregisterCommand is broken
Categories
(Chat Core :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: nhnt11, Assigned: aleth)
Details
Attachments
(2 files)
797 bytes,
application/x-javascript
|
Details | |
1.02 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 2023 at 2013-06-28 13:25:00 UTC *** After doing Services.cmd.unregisterCommand(), the command remains available to use.
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 2023 at 2013-06-28 13:42:06 UTC *** Please attach your STR.
Reporter | ||
Comment 2•10 years ago
|
||
*** Original post on bio 2023 as attmnt 2530 at 2013-06-28 13:50:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 2023 as attmnt 2531 at 2013-06-28 15:32:00 UTC *** Please test.
Attachment #8354299 -
Flags: review?(nhnt11)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment 4•10 years ago
|
||
Comment on attachment 8354299 [details] [diff] [review] Patch *** Original change on bio 2023 attmnt 2531 at 2013-06-28 15:37:07 UTC *** r=me assuming tests show that this fixes the bug.
Attachment #8354299 -
Flags: review?(nhnt11) → review+
Reporter | ||
Comment 5•10 years ago
|
||
*** Original post on bio 2023 at 2013-06-28 15:41:25 UTC *** Comment on attachment 8354299 [details] [diff] [review] (bio-attmnt 2531) Patch Tested this, works fine. Thanks!
Assignee | ||
Updated•10 years ago
|
Whiteboard: [checkin-needed]
Comment 6•10 years ago
|
||
*** Original post on bio 2023 at 2013-06-29 12:22:18 UTC *** http://hg.instantbird.org/instantbird/rev/318b01b2edfb Thanks for fixing this!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•