955460 - Services.cmd.unregisterCommand is broken

Status: RESOLVED FIXED

(Chat Core :: General, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

*** Original post on bio 2023 at 2013-06-28 13:25:00 UTC ***

After doing Services.cmd.unregisterCommand(), the command remains available to use.

Comment 1

[aleth [:aleth]]

*** Original post on bio 2023 at 2013-06-28 13:42:06 UTC ***

Please attach your STR.

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: bootstrap.js of an addon illustrating this

*** Original post on bio 2023 as attmnt 2530 at 2013-06-28 13:50:00 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 3

[aleth [:aleth]]

Attachment: Patch

*** Original post on bio 2023 as attmnt 2531 at 2013-06-28 15:32:00 UTC ***

Please test.

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8354299 [details] [diff] [review]
Patch

*** Original change on bio 2023 attmnt 2531 at 2013-06-28 15:37:07 UTC ***

r=me assuming tests show that this fixes the bug.

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

*** Original post on bio 2023 at 2013-06-28 15:41:25 UTC ***

Comment on attachment 8354299 [details] [diff] [review] (bio-attmnt 2531)
Patch

Tested this, works fine. Thanks!

Comment 6

[Patrick Cloke [:clokep]]

*** Original post on bio 2023 at 2013-06-29 12:22:18 UTC ***

http://hg.instantbird.org/instantbird/rev/318b01b2edfb

Thanks for fixing this!