955523 - Could not deccode UTF-8 message into UTF-16.

Status: RESOLVED FIXED

(Chat Core :: Yahoo! Messenger, defect)

Description

[aleth [:aleth]]

*** Original post on bio 2086 at 2013-08-02 10:05:00 UTC ***

Timestamp: 08/02/2013 12:03:02 PM
Warning: Could not deccode UTF-8 message into UTF-16. Message: Would you be my chat buddy?
Source File: resource://gre/components/yahoo.js
Line: 376

Strange, so I thought I'd file it. Automatic message received with buddy auth request.

Comment 1

[aleth [:aleth]]

*** Original post on bio 2086 at 2013-08-02 10:31:20 UTC ***

Note also the typo in the warning ;)

Comment 2

[aleth [:aleth]]

*** Original post on bio 2086 at 2013-08-02 10:38:33 UTC ***

Also 

Timestamp: 08/02/2013 12:36:36 PM
Warning: Could not encode UTF-16 message into UTF-8. Message: hi
Source File: resource://gre/components/yahoo.js
Line: 361
Source Code:
prpl-yahoo

(This message not generated by the server of course)

Comment 3

[aleth [:aleth]]

*** Original post on bio 2086 at 2013-08-02 11:38:55 UTC ***

Is this._account defined here? http://lxr.instantbird.org/instantbird/source/chat/protocols/yahoo/yahoo.js#357

Comment 4

[Quentin Headen [:qheaden]]

Attachment: Patch v1

*** Original post on bio 2086 as attmnt 2677 at 2013-08-02 17:52:00 UTC ***

This patch fixes the issue pointed out in comment 3. I've tried it, and no more error messages are shown.

Comment 5

[aleth [:aleth]]

Comment on attachment 8354446 [details] [diff] [review]
Patch v1

*** Original change on bio 2086 attmnt 2677 at 2013-08-02 17:54:29 UTC ***

You might also want to fix the typo while you're at it ;)

Comment 6

[Quentin Headen [:qheaden]]

Attachment: Patch v1 (Typo Fixed)

*** Original post on bio 2086 as attmnt 2678 at 2013-08-02 17:58:00 UTC ***

Typo fix is now included in the patch.

Comment 7

[Quentin Headen [:qheaden]]

Comment on attachment 8354446 [details] [diff] [review]
Patch v1

*** Original change on bio 2086 attmnt 2677 at 2013-08-02 17:58:42 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 8

[aleth [:aleth]]

Comment on attachment 8354447 [details] [diff] [review]
Patch v1 (Typo Fixed)

*** Original change on bio 2086 attmnt 2678 at 2013-08-02 18:00:10 UTC ***

Stealing this review to save time ;)

Comment 9

[Patrick Cloke [:clokep]]

*** Original post on bio 2086 at 2013-08-03 11:34:06 UTC ***

http://hg.instantbird.org/instantbird/rev/5455835719e4