Closed Bug 955536 Opened 6 years ago Closed 6 years ago

Buddy Conversations Should Have Close/Hold Pref

Categories

(Instantbird :: Conversation, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: qheaden, Unassigned, Mentored)

Details

(Whiteboard: [good first bug])

Attachments

(1 file, 2 obsolete files)

*** Original post on bio 2098 at 2013-08-10 09:14:00 UTC ***

Buddy conversations always close when X-ing them off. This is fine, but sometimes, it is preferable to place the conversation on hold in order to preserve the conversation history within the window.

To place a buddy conversation on hold, you must do so with the context menu, or by pressing Escape. There should be a pref that allows users to have buddy conversations placed on hold by default instead of them closing.
Whiteboard: [mentor=Mic][good first bug]
I'm not really convinced this is wanted.

It seems what you really want here is a mix of:
- undo close tab
- the awesometab working on all conversations, including irc nicks that aren't in your contact list
- the end of the log of the previous conversation being shown automatically when reopening a conversation.

I'm not really opposed to what you are requesting here if by 'pref' you meant a pref hidden in about:config. But there shouldn't be any visible UI for such a workaround.
Imho an about:config pref for this behaviour would be a good idea. Then an add-on could set it for users who prefer it.
Mentor: benediktp
Whiteboard: [mentor=Mic][good first bug] → [good first bug]
Attached patch hold.patch (obsolete) — Splinter Review
Adds a pref to put buddy conversation on hold by default through about:config
Comment on attachment 8515209 [details] [diff] [review]
hold.patch

Review of attachment 8515209 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, just some nits.

::: chat/chat-prefs.js
@@ +35,5 @@
>  // Indicates whether the core should always close conversations closed
>  // by the UI or if they can be put on hold instead.
>  pref("messenger.conversations.alwaysClose", false);
>  
> +// Put buddy conversations on hold by default. Respects alwaysClose.

At some point we changed s/buddy/contact in the UI. So...

Nit: s/buddy conversations/conversations with contacts

@@ +36,5 @@
>  // by the UI or if they can be put on hold instead.
>  pref("messenger.conversations.alwaysClose", false);
>  
> +// Put buddy conversations on hold by default. Respects alwaysClose.
> +pref("messenger.conversations.holdBuddyConversations", false);

Let's call this messenger.conversations.holdByDefault (or just .hold ?)
Attached patch hold.patch from comment 4 (obsolete) — Splinter Review
Attachment #8515209 - Attachment is obsolete: true
Attachment #8515425 - Flags: review?(aleth)
Comment on attachment 8515425 [details] [diff] [review]
hold.patch from comment 4

Review of attachment 8515425 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/chat-prefs.js
@@ +35,5 @@
>  // Indicates whether the core should always close conversations closed
>  // by the UI or if they can be put on hold instead.
>  pref("messenger.conversations.alwaysClose", false);
>  
> +// Put conversations with contacts on hold by default. Respects alwaysClose.

As this caused some confusion on #instantbird, we'd better change this to "Put conversations with contacts on hold by default (i.e. match the default behaviour for MUCs) as long as .alwaysClose is not true."
Attachment #8515425 - Attachment is obsolete: true
Attachment #8515425 - Flags: review?(aleth)
Attachment #8515491 - Flags: review?(aleth)
Comment on attachment 8515491 [details] [diff] [review]
hold.patch from comment 6

Review of attachment 8515491 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8515491 - Flags: review?(aleth) → review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.