955640 - ExistingConversations for chats don't get ranked until added from the room info api.

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

*** Original post on bio 2195 at 2013-10-02 10:06:00 UTC ***

A possible solution is to set their id's properly.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch

*** Original post on bio 2195 as attmnt 2922 at 2013-10-03 20:15:00 UTC ***

This sets the id's for ExistingConversations to the conversation id of the corresponding PossibleConversation, which results in stats being used to sort them.

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch 2

*** Original post on bio 2195 as attmnt 2925 at 2013-10-03 21:35:00 UTC ***

Store aUIConv.account in a temporary variable.

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8354693 [details] [diff] [review]
Patch

*** Original change on bio 2195 attmnt 2922 at 2013-10-03 21:35:12 UTC was without comment, so any subsequent comment numbers will be shifted ***

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8354696 [details] [diff] [review]
Patch 2

*** Original change on bio 2195 attmnt 2925 at 2013-10-03 21:38:03 UTC ***

Let's try this! :-)

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

*** Original post on bio 2195 at 2013-10-03 22:47:12 UTC ***

http://hg.instantbird.org/instantbird/rev/5b5b055e50e8