Closed Bug 955640 Opened 10 years ago Closed 10 years ago

ExistingConversations for chats don't get ranked until added from the room info api.

Categories

(Instantbird Graveyard :: Conversation, defect)

x86
Other
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nhnt11, Assigned: nhnt11)

References

Details

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 2195 at 2013-10-02 10:06:00 UTC ***

A possible solution is to set their id's properly.
Attached patch Patch (obsolete) — Splinter Review
*** Original post on bio 2195 as attmnt 2922 at 2013-10-03 20:15:00 UTC ***

This sets the id's for ExistingConversations to the conversation id of the corresponding PossibleConversation, which results in stats being used to sort them.
Attachment #8354693 - Flags: review?(florian)
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Attached patch Patch 2Splinter Review
*** Original post on bio 2195 as attmnt 2925 at 2013-10-03 21:35:00 UTC ***

Store aUIConv.account in a temporary variable.
Attachment #8354696 - Flags: review?(florian)
Comment on attachment 8354693 [details] [diff] [review]
Patch

*** Original change on bio 2195 attmnt 2922 at 2013-10-03 21:35:12 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354693 - Attachment is obsolete: true
Attachment #8354693 - Flags: review?(florian)
Comment on attachment 8354696 [details] [diff] [review]
Patch 2

*** Original change on bio 2195 attmnt 2925 at 2013-10-03 21:38:03 UTC ***

Let's try this! :-)
Attachment #8354696 - Flags: review?(florian) → review+
Blocks: 955582
Whiteboard: [checkin-needed]
*** Original post on bio 2195 at 2013-10-03 22:47:12 UTC ***

http://hg.instantbird.org/instantbird/rev/5b5b055e50e8
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [checkin-needed]
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.