Use defineLazyModuleGetter instead of defineLazyGetter

RESOLVED FIXED in 1.5

Status

Chat Core
General
--
trivial
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: clokep, Assigned: clokep)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
*** Original post on bio 2224 at 2013-10-16 14:05:00 UTC ***

There are instances we use defineLazyGetter instead of defineLazyModuleGetter, this will simplify some code, see http://mxr.mozilla.org/mozilla-central/source/accessible/src/jsat/OutputGenerator.jsm#32 as an example.
(Assignee)

Comment 1

4 years ago
Created attachment 8354742 [details] [diff] [review]
Patch

*** Original post on bio 2224 as attmnt 2961 at 2013-10-16 14:20:00 UTC ***

This depends on the patch in bug 955606 (bio 2165).
Attachment #8354742 - Flags: review?(florian)
(Assignee)

Updated

4 years ago
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Comment on attachment 8354742 [details] [diff] [review]
Patch

*** Original change on bio 2224 attmnt 2961 at 2013-10-16 14:22:33 UTC ***

Thanks!
Attachment #8354742 - Flags: review?(florian) → review+
(Assignee)

Comment 3

4 years ago
Created attachment 8354745 [details] [diff] [review]
Patch unbitrotted

*** Original post on bio 2224 as attmnt 2963 at 2013-10-18 11:39:00 UTC ***

I really bitrotted this, so I'm re-requesting review, but I think it's fine.
Attachment #8354745 - Flags: review?(florian)
(Assignee)

Comment 4

4 years ago
Comment on attachment 8354742 [details] [diff] [review]
Patch

*** Original change on bio 2224 attmnt 2961 at 2013-10-18 11:39:15 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354742 - Attachment is obsolete: true
Comment on attachment 8354745 [details] [diff] [review]
Patch unbitrotted

*** Original change on bio 2224 attmnt 2963 at 2013-10-18 12:07:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354745 - Flags: review?(florian) → review+
(Assignee)

Comment 6

4 years ago
*** Original post on bio 2224 at 2013-10-18 22:15:16 UTC ***

http://hg.instantbird.org/instantbird/rev/ff81447d30da
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.5
You need to log in before you can comment on or make changes to this bug.