Closed Bug 955673 Opened 9 years ago Closed 8 years ago

[Regression] User icon overflows its rounded border

Categories

(Instantbird :: Conversation, defect)

x86
Other
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nhnt11, Assigned: nhnt11)

References

Details

(Whiteboard: [regression])

Attachments

(1 file, 3 obsolete files)

*** Original post on bio 2225 at 2013-10-17 11:21:00 UTC ***

This was fixed by adding overflow: hidden; in bug 955465 (bio 2028), but is not working anymore. Not sure when it broke.
Whiteboard: [regression]
Attached patch Patch (obsolete) — Splinter Review
Finally got this to work by putting the image in a separate container.
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Attachment #8384141 - Flags: review?(benediktp)
Attached patch Patch v2 (obsolete) — Splinter Review
Rebase on top of patch from bug 954216.
Attachment #8384141 - Attachment is obsolete: true
Attachment #8384141 - Flags: review?(benediktp)
Attachment #8384162 - Flags: review?(benediktp)
Depends on: 954216
Attached patch Patch v3 (obsolete) — Splinter Review
Added comments mentioning that the box around the user icon is a workaround for this bug. I hope that will do?
Attachment #8384162 - Attachment is obsolete: true
Attachment #8384162 - Flags: review?(benediktp)
Attachment #8384553 - Flags: review?(benediktp)
Comment on attachment 8384553 [details] [diff] [review]
Patch v3

Review of attachment 8384553 [details] [diff] [review]:
-----------------------------------------------------------------

It's looking nice again in the contact list and new conversation tab.

That's not the case for the "conv-top" though yet. The status icon there is distorted at the moment; it is stretched to full width of the icon while keeping it's height (i.e. it's 48px x 16px now?).
Additionally MUCs are showing the border around the icon with a blank area inside.

Please check if the buddy tooltips need to be changed as well.
Attachment #8384553 - Flags: review?(benediktp) → review-
Attached patch Patch v4Splinter Review
Sorry about that. Insufficient testing. Changes in the new patch:
- Fix conversation header
- Make it work on buddy tooltips as well (this required some minor code changes aside from encapsulating the image in a box)

I tested this a little bit more thoroughly than last time and it seems to work well. :)
Attachment #8384553 - Attachment is obsolete: true
Attachment #8384966 - Flags: review?(benediktp)
Comment on attachment 8384966 [details] [diff] [review]
Patch v4

Review of attachment 8384966 [details] [diff] [review]:
-----------------------------------------------------------------

It's working fine and the changes look OK. It's not exactly a nice solution but there doesn't seem to be a better one at the moment. Thanks for fixing this!
Attachment #8384966 - Flags: review?(benediktp) → review+
rs=me until we get Mic listed as an official chat peer.
https://hg.mozilla.org/comm-central/rev/cd4d88d43146
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.