955673 - [Regression] User icon overflows its rounded border

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

*** Original post on bio 2225 at 2013-10-17 11:21:00 UTC ***

This was fixed by adding overflow: hidden; in bug 955465 (bio 2028), but is not working anymore. Not sure when it broke.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch

Finally got this to work by putting the image in a separate container.

Comment 2

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch v2

Rebase on top of patch from bug 954216.

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch v3

Added comments mentioning that the box around the user icon is a workaround for this bug. I hope that will do?

Comment 4

[Benedikt Pfeifer]

Comment on attachment 8384553 [details] [diff] [review]
Patch v3

Review of attachment 8384553 [details] [diff] [review]:
-----------------------------------------------------------------

It's looking nice again in the contact list and new conversation tab.

That's not the case for the "conv-top" though yet. The status icon there is distorted at the moment; it is stretched to full width of the icon while keeping it's height (i.e. it's 48px x 16px now?).
Additionally MUCs are showing the border around the icon with a blank area inside.

Please check if the buddy tooltips need to be changed as well.

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch v4

Sorry about that. Insufficient testing. Changes in the new patch:
- Fix conversation header
- Make it work on buddy tooltips as well (this required some minor code changes aside from encapsulating the image in a box)

I tested this a little bit more thoroughly than last time and it seems to work well. :)

Comment 6

[Benedikt Pfeifer]

Comment on attachment 8384966 [details] [diff] [review]
Patch v4

Review of attachment 8384966 [details] [diff] [review]:
-----------------------------------------------------------------

It's working fine and the changes look OK. It's not exactly a nice solution but there doesn't seem to be a better one at the moment. Thanks for fixing this!

Comment 7

[Patrick Cloke [:clokep]]

rs=me until we get Mic listed as an official chat peer.

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

https://hg.mozilla.org/comm-central/rev/cd4d88d43146