955682 - Channel cases are not properly corrected

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[Patrick Cloke [:clokep]]

*** Original post on bio 2234 at 2013-10-29 12:00:00 UTC ***

When joining a channel we use the channel case of whatever the user typed instead of what the server thinks the capitalization is.

(i.e. /join #INSTANTBIRD will not be corrected to #instantbird)

Comment 1

[AdityaSingh [:MacroMayhem]]

How should i begin working on it?

Comment 2

[aleth [:aleth]]

(In reply to AdityaSingh [:MacroMayhem] from comment #1)
> How should i begin working on it?

Take a look at a debug log to see what is sent and received from the server after /join #WRONGCAPITALIZATION, and find out at which point we receive the correct capitalization. Trace the code in chat/protocols/irc which gets called when a channel is joined (start in ircCommands looking for the join command).

Comment 3

[Patrick Cloke [:clokep]]

[1] is where we get the result that we've JOINed a new channel. Inside of that you want to check if the channel name returned from the message (the variable channelName) matches the conversation's name property. If it doesn't, we need to update the conversation's name.

[1] http://lxr.instantbird.org/instantbird/source/chat/protocols/irc/ircBase.jsm#175

Comment 4

[Patrick Cloke [:clokep]]

Attachment: Patch

Patch that fixes the issue.

Try doing /join #INSTANTBird or something, the title will get updated to #instantbird.

Comment 5

[aleth [:aleth]]

Comment on attachment 8561069 [details] [diff] [review]
Patch

Review of attachment 8561069 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 6

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/e32cb6a840d7