Tabbrowser conversations property assumes all tabs have linkedConversations

RESOLVED FIXED in 1.6

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: aleth, Assigned: nhnt11)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
*** Original post on bio 2263 at 2013-12-01 18:46:00 UTC ***

JavaScript strict warning: chrome://instantbird/content/tabbrowser.xml, line 880: reference to undefined property aTab.linkedConversation

http://lxr.instantbird.org/instantbird/source/instantbird/content/tabbrowser.xml#896
(Reporter)

Updated

5 years ago
Assignee: nobody → nhnt11
(Assignee)

Comment 1

4 years ago
Created attachment 8448610 [details] [diff] [review]
Patch
Attachment #8448610 - Flags: review?(aleth)
(Reporter)

Comment 2

4 years ago
Comment on attachment 8448610 [details] [diff] [review]
Patch

Review of attachment 8448610 [details] [diff] [review]:
-----------------------------------------------------------------

::: im/content/tabbrowser.xml
@@ +898,5 @@
>         <getter>
>          <![CDATA[
>            if (!this._conversations) {
> +            this._conversations = this.mTabs.filter(aTab => aTab.linkedConversation)
> +                                            .map(aTab => aTab.linkedConversation);

mTabs is a nodelist, not an array.
Attachment #8448610 - Flags: review?(aleth) → review-
(Assignee)

Comment 3

4 years ago
Created attachment 8448748 [details] [diff] [review]
Patch v2

Sorry about that.
Attachment #8448610 - Attachment is obsolete: true
Attachment #8448748 - Flags: review?(aleth)
(Reporter)

Comment 4

4 years ago
Comment on attachment 8448748 [details] [diff] [review]
Patch v2

Review of attachment 8448748 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8448748 - Flags: review?(aleth) → review+
(Assignee)

Comment 5

4 years ago
https://hg.mozilla.org/comm-central/rev/a3e98776154e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.