Closed Bug 955714 Opened 9 years ago Closed 9 years ago

Tabbrowser conversations property assumes all tabs have linkedConversations

Categories

(Instantbird :: Conversation, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: aleth, Assigned: nhnt11)

Details

Attachments

(1 file, 1 obsolete file)

*** Original post on bio 2263 at 2013-12-01 18:46:00 UTC ***

JavaScript strict warning: chrome://instantbird/content/tabbrowser.xml, line 880: reference to undefined property aTab.linkedConversation

http://lxr.instantbird.org/instantbird/source/instantbird/content/tabbrowser.xml#896
Assignee: nobody → nhnt11
Attached patch Patch (obsolete) — Splinter Review
Attachment #8448610 - Flags: review?(aleth)
Comment on attachment 8448610 [details] [diff] [review]
Patch

Review of attachment 8448610 [details] [diff] [review]:
-----------------------------------------------------------------

::: im/content/tabbrowser.xml
@@ +898,5 @@
>         <getter>
>          <![CDATA[
>            if (!this._conversations) {
> +            this._conversations = this.mTabs.filter(aTab => aTab.linkedConversation)
> +                                            .map(aTab => aTab.linkedConversation);

mTabs is a nodelist, not an array.
Attachment #8448610 - Flags: review?(aleth) → review-
Attached patch Patch v2Splinter Review
Sorry about that.
Attachment #8448610 - Attachment is obsolete: true
Attachment #8448748 - Flags: review?(aleth)
Comment on attachment 8448748 [details] [diff] [review]
Patch v2

Review of attachment 8448748 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8448748 - Flags: review?(aleth) → review+
https://hg.mozilla.org/comm-central/rev/a3e98776154e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.6
You need to log in before you can comment on or make changes to this bug.