955714 - Tabbrowser conversations property assumes all tabs have linkedConversations

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[aleth [:aleth]]

*** Original post on bio 2263 at 2013-12-01 18:46:00 UTC ***

JavaScript strict warning: chrome://instantbird/content/tabbrowser.xml, line 880: reference to undefined property aTab.linkedConversation

http://lxr.instantbird.org/instantbird/source/instantbird/content/tabbrowser.xml#896

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch

Comment 2

[aleth [:aleth]]

Comment on attachment 8448610 [details] [diff] [review]
Patch

Review of attachment 8448610 [details] [diff] [review]:
-----------------------------------------------------------------

::: im/content/tabbrowser.xml
@@ +898,5 @@
>         <getter>
>          <![CDATA[
>            if (!this._conversations) {
> +            this._conversations = this.mTabs.filter(aTab => aTab.linkedConversation)
> +                                            .map(aTab => aTab.linkedConversation);

mTabs is a nodelist, not an array.

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Patch v2

Sorry about that.

Comment 4

[aleth [:aleth]]

Comment on attachment 8448748 [details] [diff] [review]
Patch v2

Review of attachment 8448748 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

https://hg.mozilla.org/comm-central/rev/a3e98776154e