Closed
Bug 955734
Opened 10 years ago
Closed 10 years ago
this._account is undefined on Connection reset
Categories
(Chat Core :: IRC, defect)
Chat Core
IRC
Tracking
(Not tracked)
RESOLVED
FIXED
1.5
People
(Reporter: aleth, Assigned: aleth)
Details
(Whiteboard: [1.5-blocking][regression])
Attachments
(1 file, 1 obsolete file)
1.05 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
*** Original post on bio 2283 at 2013-12-13 15:10:00 UTC *** Leads to a failure to disconnect, and therefore to a failure to reconnect Error: Connection reset Error: this._account is undefined, line 714 irc.js Error: Reveived unexpected ERROR response (Ping timeout), 7 minutes later.
Assignee | ||
Updated•10 years ago
|
OS: Linux → All
Hardware: x86 → All
Whiteboard: [1.5-blocking][regression]
Assignee | ||
Comment 1•10 years ago
|
||
*** Original post on bio 2283 as attmnt 3119 at 2013-12-13 17:14:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354904 -
Flags: review?(clokep)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Comment 2•10 years ago
|
||
Comment on attachment 8354904 [details] [diff] [review] Patch *** Original change on bio 2283 attmnt 3119 at 2013-12-13 17:42:36 UTC *** Can we get rid of the { } and put the comment above the if statement? Besides that, looks fine.
Attachment #8354904 -
Flags: review?(clokep) → review-
Assignee | ||
Comment 3•10 years ago
|
||
*** Original post on bio 2283 as attmnt 3120 at 2013-12-13 17:57:00 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354905 -
Flags: review?(clokep)
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8354904 [details] [diff] [review] Patch *** Original change on bio 2283 attmnt 3119 at 2013-12-13 17:57:52 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354904 -
Attachment is obsolete: true
Comment 5•10 years ago
|
||
Comment on attachment 8354905 [details] [diff] [review] Patch2 *** Original change on bio 2283 attmnt 3120 at 2013-12-13 18:04:44 UTC was without comment, so any subsequent comment numbers will be shifted ***
Attachment #8354905 -
Flags: review?(clokep) → review+
Assignee | ||
Updated•10 years ago
|
Whiteboard: [1.5-blocking][regression] → [1.5-blocking][regression][checkin-needed]
Comment 6•10 years ago
|
||
*** Original post on bio 2283 at 2013-12-13 21:08:33 UTC *** http://hg.instantbird.org/instantbird/rev/027b2bfed093
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [1.5-blocking][regression][checkin-needed] → [1.5-blocking][regression]
Target Milestone: --- → 1.5
You need to log in
before you can comment on or make changes to this bug.
Description
•