955747 - Twitter support in russian locale is broken

Status: RESOLVED FIXED

(Chat Core :: Twitter, defect)

Description

[Instantbot]

*** Original post on bio 2294 by Igor <kantsuris AT gmail.com> at 2013-12-23 05:08:00 UTC ***

When leaving the stable version in Russian disappears twitter!

Comment 1

[Patrick Cloke [:clokep]]

*** Original post on bio 2294 at 2013-12-23 14:02:48 UTC ***

I don't understand what you mean, can you please describe step-by-step what is happening and what you expect to happen?

Comment 2

[Instantbot]

*** Original post on bio 2294 by Igor <kantsuris AT gmail.com> at 2013-12-23 18:04:53 UTC ***

Russian version non twitter !

Comment 3

[Benedikt Pfeifer]

*** Original post on bio 2294 at 2013-12-25 20:47:57 UTC ***

I can confirm that the russian locale doesn't contain Twitter in any of it's protocol lists. Here's the error from the console:

Метка времени: 25.12.2013 21:42:57
Ошибка: Could not initialize protocol prpl-twitter: [Exception... "'Creating an instance of prpl-twitter but this object implements prpl-B28BB5@' when calling method: [prplIProtocol::init]"  nsresult: "0x8057001e (NS_ERROR_XPC_JS_THREW_STRING)"  location: "JS frame :: resource://gre/components/imCore.js :: <TOP_LEVEL> :: line 338"  data: no]
Источник: resource://gre/components/imCore.js
Строка: 340

Comment 4

[Benedikt Pfeifer]

*** Original post on bio 2294 at 2013-12-25 21:16:12 UTC ***

Cause of the problem is that we're localizing the protocol name now [1] and this localized name is used by jsProtoHelper [2] to create the id of the protocol.

Adding a getter for the id that returns "prpl-twitter" fixes the problem for me. 

[1] https://hg.instantbird.org/instantbird/file/e119e96ba074/chat/protocols/twitter/twitter.js#l1085
[2] https://hg.instantbird.org/instantbird/file/e119e96ba074/chat/modules/jsProtoHelper.jsm#l757

I think we should hardcode the id from now on.

Comment 5

[Patrick Cloke [:clokep]]

Attachment: Patch

Other protocols just override normalizedName, which I believe is the "right" fix since this is also used for various comparison.

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 8389788 [details] [diff] [review]
Patch

Thanks!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/b63aa9c26ecf