955815 - ecma_6/TypedObject/simd/float32x4abs.js will be permaorange on the February 3rd merge to mozilla-aurora

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Phil Ringnalda (:philor)]

According to https://tbpl.mozilla.org/?tree=Try&rev=54ef3ee8c675&jobname=jsreftest, which is current mozilla-central pushed to try as though it had been merged to mozilla-aurora, if it doesn't get fixed ecma_6/TypedObject/simd/float32x4abs.js will be permaorange once whatever nightly-only thing it depends on is shut off.

Comment 1

[Till Schneidereit [:till]]

I'm pretty sure that the SIMD stuff isn't supposed to ride the next train, so the test has to be fixed to take that into account. (Though I'd slightly prefer for experimental features like SIMD to make it to Aurora, but not to Beta.)

Comment 2

[Niko Matsakis [:nmatsakis]]

till is correct.

Comment 3

[Niko Matsakis [:nmatsakis]]

there is a flag that needs to be added to the tests, similar to what appears on the typed object tests.

Comment 4

[Niko Matsakis [:nmatsakis]]

Attachment: Bug955815.diff

Changes to tests are auto r+, I suppose.

Comment 5

[Niko Matsakis [:nmatsakis]]

https://tbpl.mozilla.org/?tree=Try&rev=9edc4c9b0c33

Comment 6

[Phil Ringnalda (:philor)]

I certainly treat them as not requiring review, unless I want someone to tell me whether I'm doing it right or I want someone to share the blame :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/bcc2c29c1e16

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/bcc2c29c1e16