Closed Bug 955838 Opened 10 years ago Closed 10 years ago

Remove enclosingScriptsCompiledSuccessfully

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla29

People

(Reporter: jandem, Assigned: jandem)

Details

Attachments

(2 files, 1 obsolete file)

Patch
6.76 KB, patch
bhackett1024
: review+
Details | Diff | Splinter Review
Remove JS_DumpBytecode
1.87 KB, patch
bhackett1024
: review+
Details | Diff | Splinter Review
Attached patch Patch (obsolete) — — Splinter Review 
This patch removes the unused JS_DumpCompartmentBytecode (and IsOriginalScriptFunction) functions.

With that gone, JS_DumpCompartmentPCCounts is the only place where we call enclosingScriptsCompiledSuccessfully, but I think it's unnecessary there, because if a script has script counts, it must have been compiled successfully.
Attachment #8354988 - Flags: review?(bhackett1024)
Attached patch Patch — — Splinter Review 
Let's remove more dead code.
Attachment #8354988 - Attachment is obsolete: true
Attachment #8354988 - Flags: review?(bhackett1024)
Attachment #8354989 - Flags: review?(bhackett1024)
JS_DumpBytecode is now dead as well. Note that js_DumpScript is more-or-less identical, so people can still use that in gdb etc.
Attachment #8354990 - Flags: review?(bhackett1024)
Attachment #8354989 - Flags: review?(bhackett1024) → review+
Attachment #8354990 - Flags: review?(bhackett1024) → review+
\o/
https://hg.mozilla.org/mozilla-central/rev/f2a8abb150cd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: