Closed Bug 955861 Opened 11 years ago Closed 10 years ago

Long-tapping on reader mode toolbar icons triggers text selection mode

Categories

(Firefox for Android Graveyard :: Reader View, defect)

Product:
Firefox for Android Graveyard
Component:
Reader View
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox27 unaffected, firefox28 verified, firefox29 verified, b2g18?)

Status:
VERIFIED FIXED
Milestone:
Firefox 29
Tracking Flags:
Tracking Status
firefox27 --- unaffected
firefox28 --- verified
firefox29 --- verified
b2g18 ? ---

People

(Reporter: pretzer, Assigned: wesj)

References

Details

(Keywords: regression, reproducible)

Attachments

(1 file)

readerbutton
659 bytes, patch
lucasr
: review+
bajaj
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Long-tapping on reader mode toolbar icons which have text below them triggers text selection mode. Somehow the tap bleeds through the toolbar onto the content below.
Do we care about this? If we do, should set the tracking-firefox# flags as well.
status-firefox27: --- → unaffected
tracking-b2g18: --- → ?
Just to be clear, I don't think this should block bug 768667. Just nice to have. Fix should be relatively simple though.
Attached patch readerbutton — — Splinter Review 

        Attachment #8356835 -
        Flags: review?(lucasr.at.mozilla)

        Attachment #8356835 -
        Attachment is patch: true

        Attachment #8356835 -
        Flags: review?(lucasr.at.mozilla) → review+

    
  
Assignee: nobody → wjohnston
Status: NEW → ASSIGNED

    
  
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8356835 [details] [diff] [review]
readerbutton

[Approval Request Comment]
Bug caused by (feature/regressing bug #): actionbar
User impact if declined: buttons out of order. want to stay consistent with our first release of this
Testing completed (on m-c, etc.): been on mc for a week
Risk to taking this patch (and alternatives if risky): pretty low risk. just changing the order
String or IDL/UUID changes made by this patch: none.

        Attachment #8356835 -
        Flags: approval-mozilla-aurora?

          status-firefox29:
          affected → fixed
Target Milestone: --- → Firefox 29

        Attachment #8356835 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
    

    
  
Verified fixed on:
Build: Firefox for Android 29.0a2( 2014-02-10) and Firefox for Android 28 Beta 1 
Device: LG Nexus 4
OS: Android 4.4.
Status: RESOLVED → VERIFIED

          status-firefox28:
          fixed → verified

          status-firefox29:
          fixed → verified

    
  
Product: Firefox for Android → Firefox for Android Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: