955910 - Conference room numbers jump two values

Status: RESOLVED FIXED

(Chat Core :: Yahoo! Messenger, defect)

Description

[Quentin Headen [:qheaden]]

When creating conference rooms using JS-Yahoo, the conference room numbers are 1, 3, 5, etc. They need to only jump one value at a time.

Comment 1

[Quentin Headen [:qheaden]]

Attachment: Patch 1

This patch fixes the issue of conference room numbers. I removed one of the increment statements that was double incrementing the numbers.

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8360829 [details] [diff] [review]
Patch 1

Review of attachment 8360829 [details] [diff] [review]:
-----------------------------------------------------------------

I'm glad this was so simple to figure out! I just have one small nit.

::: chat/protocols/yahoo/yahoo.js
@@ +459,5 @@
>    get canJoinChat() true,
>    chatRoomFields: {},
>    joinChat: function(aComponents) {
> +    // Use _roomsCreated to append a unique number to the room name.
> +    this._roomsCreated++;

Nit: ++this._roomsCreated;

Comment 3

[Quentin Headen [:qheaden]]

Attachment: Patch 2

This patch uses the prefix increment operator instead of postfix. Also, I removed the increment operation as a separate line, and simply moved it in-line with the assignment of the room name.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/d69fef57ca19