Closed Bug 955955 Opened 11 years ago Closed 11 years ago

Missing descriptors for 18+ rating

Categories

(Marketplace Graveyard :: Developer Pages, defect, P2)

defect

Tracking

(Not tracked)

VERIFIED FIXED
2014-01-14

People

(Reporter: krupa.mozbugs, Assigned: kngo)

References

()

Details

(Whiteboard: [incorrect_implementation])

Attachments

(2 files)

Attached image missing descriptor.png
steps to reproduce:
1. Load https://marketplace-dev.allizom.org/developers/app/test-app-te/content_ratings
2. Notice that there are no descriptors

observed behavior:
ESRB site has a bunch of descriptors for a 18+ rating. This is missing from our Content Rating page.

See screenshot.
Assignee: nobody → kngo
Priority: -- → P1
Priority: P1 → P2
Has this been partially fixed?
https://marketplace-dev.allizom.org/developers/app/test-app-te/content_ratings
has descriptors for everywhere other than ERSB and Germany now.
(In reply to Andrew Williamson [:eviljeff] from comment #1)
> Has this been partially fixed?
> https://marketplace-dev.allizom.org/developers/app/test-app-te/
> content_ratings
> has descriptors for everywhere other than ERSB and Germany now.

no, the descriptors show up upon retriggering the quiz or after a few days. So, it isn't fixed.
I took a quick look at this from our end to see if I could provide any helpful information. I found 14 records in our log for the Demo system from 12/11/13 to 1/6/13 indicating that a Pingback request was sent and the server returned a 500 Internal Server Error. This includes the Pingback sent for Submission ID 286 in the attached screenshot. I have the full text of each of these requests and can provide them if they will be of any help. I do not, however, have the PingbackURL the requests were sent to.
Krupa, could you try again please?

I was able to pull down USK descriptors https://marketplace-dev.allizom.org/developers/app/lucid/content_ratings

I added some logging just in case you can reproduce it, I'll have debugging information.
Flags: needinfo?(krupa.mozbugs+1)
Flags: needinfo?(krupa.mozbugs+1)
Krupa, can you attach a screenshot of the IARC ratings certificate so I see what's missing?
Attached image missing descriptors.png
Just noticed that this issue is fixed if the user navigates away from this page and comes back.
Thanks, I think I know the solution (race condition).
https://github.com/mozilla/zamboni/commit/9533d609e546a5d1a6787fa520882e9fab7f5cfb

Race condition details:

    User gets content rating through IARC tool.
    set_content_ratings creates content rating.
    Front-end which is polling ContentRatings API triggers a refresh before the descriptors are created.
    Page is refreshed and descriptors aren't shown because they weren't created yet.
    Refreshing the page again shows the descriptors.

tldr; set_content_ratings asynchronously triggers a page refresh somewhere else before descriptors are created.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-01-14
Verified as fixed in https://marketplace-dev.allizom.org/developers/ on FF29 (Win 7).
Postfix screencast http://screencast.com/t/Lxg3bMtY
Closing bug.
Status: RESOLVED → VERIFIED
Iulian,

I'm concerned with how long it takes to generate the rating and ping-back the Dev Portal once the "Confirm" button is selected (over 15 seconds).  Is this the normal response time Mozilla has been experiencing?  We don't seem to experience the same delay.

Please let me know.  Thanks
The ping-back comes relatively quickly (~1.5 seconds) and our page refreshes.

Though I think the spinner on the IARC tool keeps spinning despite this, which may lead to some users waiting for the spinner to clear before moving back to our pages.
Whiteboard: [incorrect_implementation]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: