Closed Bug 955994 Opened 11 years ago Closed 10 years ago

Running preferences.js on node.js

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: yurenju, Assigned: rickychien)

References

Details

Attachments

(1 file)

[gaia] RickyChien:preferences-to-nodejs > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gduan
: review+
Details | Review 
+++ This bug was initially created as a clone of Bug #955988 +++
Summary: [meta] Running preferences.js on node.js → Running preferences.js on node.js
Assignee: nobody → yurenju.mozilla
un-assign myself since I don't have enough bandwidth to fix it.
Assignee: yurenju → nobody
Blocks: 955988
No longer depends on: 955988
Assignee: nobody → ricky060709
Status: NEW → ASSIGNED

  

  



    
    

    
  
Comment on attachment 8569668 [details] [review]
[gaia] RickyChien:preferences-to-nodejs > mozilla-b2g:master

I've verified build result by comparing RUN_ON_NODE=0 / 1 flags. Please check it carefully thanks!

  

  



        Attachment #8569668 -
        Flags: review?(gduan)

    
    

    
  
Comment on attachment 8569668 [details] [review]
[gaia] RickyChien:preferences-to-nodejs > mozilla-b2g:master

r=gduan

  

  



        Attachment #8569668 -
        Flags: review?(gduan) → review+

    
    

    
  
Landed in master:

https://github.com/mozilla-b2g/gaia/commit/3a2ceabfe1b0d7516dd528bc18724acb22d12f7c

  

  


Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Priority: -- → P1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: