Running webapp-manifests.js on node.js

RESOLVED FIXED

Status

Firefox OS
Gaia
P1
normal
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: yurenju, Assigned: gduan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

+++ This bug was initially created as a clone of Bug #955988 +++
Assignee: nobody → alive
\o/
Inactive, unassign ;)
Assignee: alive → nobody
Blocks: 955988
No longer depends on: 955988
Assignee: nobody → gduan
Status: NEW → ASSIGNED
Created attachment 8564938 [details] [review]
[gaia] cctuan:955997 > mozilla-b2g:master
Comment on attachment 8564938 [details] [review]
[gaia] cctuan:955997 > mozilla-b2g:master

Hi Ricky,
I've compared webapps.json from profile with/without my patch , and the result is good.
Please kindly check, thanks.
Attachment #8564938 - Flags: review?(ricky060709)
Comment on attachment 8564938 [details] [review]
[gaia] cctuan:955997 > mozilla-b2g:master

Set this bug depends on bug 1131499 since Node switcher API has been tweaked.

Please set r=me again once you fix new API changes after bug 1131499 is landed.
Attachment #8564938 - Flags: review?(ricky060709)
Depends on: 1131499
Comment on attachment 8564938 [details] [review]
[gaia] cctuan:955997 > mozilla-b2g:master

Hi Ricky,
please check again this patch, thanks!

I think we should also file a bug to have sinon in build unit test.
Attachment #8564938 - Flags: review?(ricky060709)
Comment on attachment 8564938 [details] [review]
[gaia] cctuan:955997 > mozilla-b2g:master

Patch seems fine to me. Let's land it!
Attachment #8564938 - Flags: review?(ricky060709) → review+
master: https://github.com/mozilla-b2g/gaia/commit/cc235a867161e0000ea55a4f009b3be19021f066
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Priority: -- → P1
You need to log in before you can comment on or make changes to this bug.