955997 - Running webapp-manifests.js on node.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

+++ This bug was initially created as a clone of Bug #955988 +++

Comment 1

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

\o/

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Inactive, unassign ;)

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] cctuan:955997 > mozilla-b2g:master

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8564938 [details] [review]
[gaia] cctuan:955997 > mozilla-b2g:master

Hi Ricky,
I've compared webapps.json from profile with/without my patch , and the result is good.
Please kindly check, thanks.

Comment 5

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8564938 [details] [review]
[gaia] cctuan:955997 > mozilla-b2g:master

Set this bug depends on bug 1131499 since Node switcher API has been tweaked.

Please set r=me again once you fix new API changes after bug 1131499 is landed.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8564938 [details] [review]
[gaia] cctuan:955997 > mozilla-b2g:master

Hi Ricky,
please check again this patch, thanks!

I think we should also file a bug to have sinon in build unit test.

Comment 7

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8564938 [details] [review]
[gaia] cctuan:955997 > mozilla-b2g:master

Patch seems fine to me. Let's land it!

Comment 8

[(Inactive after June) George Duan [:gduan] [:喬智]]

master: https://github.com/mozilla-b2g/gaia/commit/cc235a867161e0000ea55a4f009b3be19021f066