955998 - Running webapp-optimize.js on node.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

+++ This bug was initially created as a clone of Bug #955988 +++

Comment 1

[(Inactive after June) George Duan [:gduan] [:喬智]]

https://github.com/tmpvar/jsdom/issues/961
currently, jsdom cannot read dataset property.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

Currenly, there're some issues encountered.
1. jsdom-nogyp: outerHTML only has get property
=> workaround to defineSetter for jsdom.dom.level3.html.Element outerHTML
2. jsdom-nogyp: compareDocumentPosition when doing document.querySelector('script[src$="l10n.js"]') 
=> after put jsdom.level(3, 'html'), the error is gone, however, the html cannot be parsed successfully
3. esprima: jsComparator cannot work with it. still investigating.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

It turns out our node.ls doesn't really do the filter pattern.
After new patch,
diff with "make PRODUCTION=1" would have some thing different on NODE,
1. <!-- <script> --> would be gone, since jsdom's limited api, but I think that doesn't affect the functionality
2. <input /> ---> <input> , still jsdom, but that doesn't affect functionality
3. <input type="text" class="xxx"> ---> <input class="xxx" type="text"> , still jsdom, but doesn't affect

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Since we have new plan for buildscript, I would deassign myself on this bug for now. Feel free to take it.

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] rickychien:webapp-optimize-to-nodejs > mozilla-b2g:master

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8708796 [details] [review]
[gaia] rickychien:webapp-optimize-to-nodejs > mozilla-b2g:master

Scott, one of our migration's difficult part is done.

Remember that OPTIMIZE mode doesn't enable by default so please be aware of GAIA_OPTIMIZE=1 when you're trying to test it.

command:

make RUN_ON_NODE=1 GAIA_OPTIMIZE=1 or pass GAIA_OPTIMIZE=1 to node-build-diff.sh

Comment 7

[Ricky Chien [:rickychien] (inactive)]

P.S. Modify FLAG variable FLAG="GAIA_OPTIMIZE=1" at line 8 in node-build-diff.sh to enable optimization.

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8708796 [details] [review]
[gaia] rickychien:webapp-optimize-to-nodejs > mozilla-b2g:master

Hi Zibi,

shared/js/language_list.js is touched since it used array comprehensions that is unrecognized by esprima [1]. I noticed you are the person who modified this script last time so I'd like to inform you this changes.

We should be aware of using some ES6 syntax which node.js (V8) doesn't support yet during or after build system migration to node.js.

[1] http://esprima.org

Comment 9

[Scott Wu [:scottwu]]

Comment on attachment 8708796 [details] [review]
[gaia] rickychien:webapp-optimize-to-nodejs > mozilla-b2g:master

Tested on device okay and diff looks fine except some anomalies [1]. r+

[1]: SVG tag <feColorMatrix> became <fecolormatrix> when built with node, but works fine on device.

Comment 10

[Ricky Chien [:rickychien] (inactive)]

Landed in master:

https://github.com/mozilla-b2g/gaia/commit/9d6b1f54276ee50d8fd7a5623e2169ac8afec0c1

Comment 11

[:gerard-majax]

I have updated one of my dogfooding devices and got Homescreen broken because of:
> 01-29 19:12:30.139  1448  1448 E Default Home Screen: [JavaScript Error: "TypeError: this.settings is undefined" {file: "app://homescreen.gaiamobile.org/gaia_build_defer_index.js" line: 862}]

After manually reinstalling homescreen with and without gaia optimize flag, it seems the GAIA_OPTIMIZE=1 might be the reason why it broke in the first place.

Comment 12

[:gerard-majax]

After a cleanup of gaia/profile* and rebuilding and testing several times I could not reproduce. So maybe a one thing that happens at the "migration" time with previous profile builds already here