Closed
Bug 956095
Opened 9 years ago
Closed 9 years ago
Compiler warnings in mozilla-central/xpcom/tests/TestCOMArray.cpp
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: iosifadrianmihai, Assigned: iosifadrianmihai)
Details
Attachments
(1 file, 1 obsolete file)
1.56 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0 (Beta/Release) Build ID: 20130201190337 Steps to reproduce: ./mach build Actual results: 0:36.18 Warning: -Wuninitialized in /home/andu/mozilla/mozilla-central/xpcom/tests/TestCOMArray.cpp: ‘fifthObject’ may be used uninitialized in this function 0:36.18 mozilla-central/xpcom/tests/TestCOMArray.cpp:242:7: warning: ‘fifthObject’ may be used uninitialized in this function [-Wuninitialized] 0:36.18 Warning: -Wuninitialized in /mozilla/mozilla-central/xpcom/tests/TestCOMArray.cpp: ‘fourthObject’ may be used uninitialized in this function 0:36.18 /mozilla-central/xpcom/tests/TestCOMArray.cpp:239:7: warning: ‘fourthObject’ may be used uninitialized in this function [-Wuninitialized] 0:36.18 Warning: -Wuninitialized in /mozilla-central/xpcom/tests/TestCOMArray.cpp: ‘thirdObject’ may be used uninitialized in this function 0:36.18 /mozilla-central/xpcom/tests/TestCOMArray.cpp:236:7: warning: ‘thirdObject’ may be used uninitialized in this function [-Wuninitialized] 0:36.18 Warning: -Wuninitialized in /home/andu/mozilla/mozilla-central/xpcom/tests/TestCOMArray.cpp: ‘fifthObject’ may be used uninitialized in this function 0:36.18 /mozilla-central/xpcom/tests/TestCOMArray.cpp:242:7: warning: ‘fifthObject’ may be used uninitialized in this function [-Wuninitialized] 0:36.18 Warning: -Wuninitialized in /mozilla-central/xpcom/tests/TestCOMArray.cpp: ‘fourthObject’ may be used uninitialized in this function 0:36.18 /mozilla-central/xpcom/tests/TestCOMArray.cpp:239:7: warning: ‘fourthObject’ may be used uninitialized in this function [-Wuninitialized] 0:36.18 Warning: -Wuninitialized in /home/andu/mozilla/mozilla-central/xpcom/tests/TestCOMArray.cpp: ‘thirdObject’ may be used uninitialized in this function 0:36.18 /mozilla-central/xpcom/tests/TestCOMArray.cpp:236:7: warning: ‘thirdObject’ may be used uninitialized in this function [-Wuninitialized]
Assignee | ||
Comment 1•9 years ago
|
||
Any kind of feedback would be much appreciated (I'm new to contributing). Thank you!
Attachment #8355260 -
Flags: review?(doug.turner)
Comment 2•9 years ago
|
||
Comment on attachment 8355260 [details] [diff] [review] fixes warnings; initializes pointers Review of attachment 8355260 [details] [diff] [review]: ----------------------------------------------------------------- any reason not to use null? ::: xpcom/tests/TestCOMArray.cpp @@ +179,5 @@ > int32_t base; > { > Array2 arr2; > > + IBar *thirdObject = 0, null?
Attachment #8355260 -
Flags: review?(doug.turner) → review-
Comment 3•9 years ago
|
||
I think Doug means nullptr. :-)
Assignee | ||
Comment 4•9 years ago
|
||
Changed initializing to nullptr.
Attachment #8357100 -
Flags: review?(doug.turner)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(doug.turner)
Comment 5•9 years ago
|
||
Comment on attachment 8357100 [details] [diff] [review] fixes warnings; initializes pointers (nullptr) Review of attachment 8357100 [details] [diff] [review]: ----------------------------------------------------------------- lgtm
Attachment #8357100 -
Flags: review?(doug.turner) → review+
Updated•9 years ago
|
Flags: needinfo?(doug.turner)
Keywords: checkin-needed
Updated•9 years ago
|
Attachment #8355260 -
Attachment is obsolete: true
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/796c5b4ce470
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in
before you can comment on or make changes to this bug.
Description
•