956095 - Compiler warnings in mozilla-central/xpcom/tests/TestCOMArray.cpp

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Iosif Adrian Mihai]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0 (Beta/Release)
Build ID: 20130201190337

Steps to reproduce:

./mach build


Actual results:

 0:36.18 Warning: -Wuninitialized in /home/andu/mozilla/mozilla-central/xpcom/tests/TestCOMArray.cpp: ‘fifthObject’ may be used uninitialized in this function
 0:36.18 mozilla-central/xpcom/tests/TestCOMArray.cpp:242:7: warning: ‘fifthObject’ may be used uninitialized in this function [-Wuninitialized]
 0:36.18 Warning: -Wuninitialized in /mozilla/mozilla-central/xpcom/tests/TestCOMArray.cpp: ‘fourthObject’ may be used uninitialized in this function
 0:36.18 /mozilla-central/xpcom/tests/TestCOMArray.cpp:239:7: warning: ‘fourthObject’ may be used uninitialized in this function [-Wuninitialized]
 0:36.18 Warning: -Wuninitialized in /mozilla-central/xpcom/tests/TestCOMArray.cpp: ‘thirdObject’ may be used uninitialized in this function
 0:36.18 /mozilla-central/xpcom/tests/TestCOMArray.cpp:236:7: warning: ‘thirdObject’ may be used uninitialized in this function [-Wuninitialized]

 0:36.18 Warning: -Wuninitialized in /home/andu/mozilla/mozilla-central/xpcom/tests/TestCOMArray.cpp: ‘fifthObject’ may be used uninitialized in this function
 0:36.18 /mozilla-central/xpcom/tests/TestCOMArray.cpp:242:7: warning: ‘fifthObject’ may be used uninitialized in this function [-Wuninitialized]
 0:36.18 Warning: -Wuninitialized in /mozilla-central/xpcom/tests/TestCOMArray.cpp: ‘fourthObject’ may be used uninitialized in this function
 0:36.18 /mozilla-central/xpcom/tests/TestCOMArray.cpp:239:7: warning: ‘fourthObject’ may be used uninitialized in this function [-Wuninitialized]
 0:36.18 Warning: -Wuninitialized in /home/andu/mozilla/mozilla-central/xpcom/tests/TestCOMArray.cpp: ‘thirdObject’ may be used uninitialized in this function
 0:36.18 /mozilla-central/xpcom/tests/TestCOMArray.cpp:236:7: warning: ‘thirdObject’ may be used uninitialized in this function [-Wuninitialized]

Comment 1

[Iosif Adrian Mihai]

Attachment: fixes warnings; initializes pointers

Any kind of feedback would be much appreciated (I'm new to contributing). Thank you!

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 8355260 [details] [diff] [review]
fixes warnings; initializes pointers

Review of attachment 8355260 [details] [diff] [review]:
-----------------------------------------------------------------

any reason not to use null?

::: xpcom/tests/TestCOMArray.cpp
@@ +179,5 @@
>    int32_t base;
>    {
>      Array2 arr2;
>  
> +    IBar *thirdObject = 0,

null?

Comment 3

[(no longer active)]

I think Doug means nullptr.  :-)

Comment 4

[Iosif Adrian Mihai]

Attachment: fixes warnings; initializes pointers (nullptr)

Changed initializing to nullptr.

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 8357100 [details] [diff] [review]
fixes warnings; initializes pointers (nullptr)

Review of attachment 8357100 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/796c5b4ce470

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/796c5b4ce470