Closed Bug 956151 Opened 9 years ago Closed 9 years ago

Remove the perm attribute in permissions.js

Categories

(Firefox :: Preferences, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 29

People

(Reporter: ytx, Assigned: ytx)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

The perm attribute in the Permission object at http://dxr.mozilla.org/mozilla-central/source/browser/components/preferences/permissions.js#17 is never used, except on line 108.

Also, this attribute isn't updated when changing permissions, leading to not being able to change a permission after it has been changed once.
I'd like to work on this bug, could someone assign me please?
Blocks: 310619
Assignee: nobody → ytxmoz
Attached patch PatchSplinter Review
Attachment #8355512 - Flags: review?(dao)
Comment on attachment 8355512 [details] [diff] [review]
Patch

Thanks!
Attachment #8355512 - Flags: review?(dao) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8c2acf0267ac
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.