Closed
Bug 956160
Opened 10 years ago
Closed 10 years ago
UITour: Highlight panel looks unsurprisingly ugly with a border
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 29
People
(Reporter: Unfocused, Assigned: Unfocused)
References
Details
Attachments
(1 file)
|
923 bytes,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
Whoops, this shouldn't have a border. -moz-appearance:none isn't enough, as it then just inherits a border.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8355358 -
Flags: review?(MattN+bmo)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Works fine if the window isn't maximized and isn't hard up against the right edge of the monitor. So, I'd say this is another issue caused by using a <xul:panel>. Between this and bug 943759, which I believe is also caused by using <xul:panel>, I think we should consider the possibility of needing to revert back to using a <html:div>. Thoughts, Matt?
Flags: needinfo?(MattN+bmo)
|
|
Assignee | |
Comment 3•10 years ago
|
||
*sigh* Wrong bug, please ignore comment 2.
Flags: needinfo?(MattN+bmo)
|
|
Assignee | |
Comment 4•10 years ago
|
||
(And redirect any thoughts to bug 956162.)
|
||
Comment 5•10 years ago
|
||
Comment on attachment 8355358 [details] [diff] [review] Patch v1 Which platform did you see the bug on? I didn't see it on OS X.
Attachment #8355358 -
Flags: review?(MattN+bmo) → review+
|
|
||
Comment 6•10 years ago
|
||
I see the problem on Windows now.
|
|
Assignee | |
Comment 7•10 years ago
|
||
Yea, was testing on Windows. https://hg.mozilla.org/integration/fx-team/rev/28dce9a7c09b
|
||
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/28dce9a7c09b
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
You need to log in
before you can comment on or make changes to this bug.
Description
•