956184 - [keyboard refactor] merge refactored keyboard into apps/keyboard

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[David Flanagan [:djf]]

Once the refactored keyboard in test_apps/demo-keyboard/ reaches feature parity with the system keyboard, we need to merge it into the apps/keyboard/ directory.

This is complicated by the fact that the refactoring is only for latin layouts and we are leaving the asian layouts with the existing codebase for now.

This will require changes to the build system because we'll have to specify different entry points in the manifest file for latin vs. asian keyboards.

We could also use the bug to completely overhaul the keyboard build system. Now that apps can have their own build directories, we could move the data files in gaia/keyboards/ into apps/keyboard/ without having them end up in the zip file and this would be cleaner.  

It would also be nice if we could modify the build system so that asian IMEs and their dictionaries were included in the packaged app only if enabled at build time.

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

As we discussed last week, I don't think it's feasible for this to wait until feature parity.

Jan, is it possible for you to take this work first? Some simple idea in mind:

-- Modify build script so that it would pick layouts from layouts from both new keyboard app and old keyboard app. Temporary append the layouts of the new keyboard with "2", e.g. "en2", so that

GAIA_KEYBOARD_LAYOUTS=en2

builds English layout from new keyboard instead of the current one.

-- Remove all the code of the new keyboard in the package if none of the new keyboard layouts are enabled, and vise versa.

I am plotting this work against the fact we must be able to pref off the feature on branches if we ended up deciding to. djf, does this make sense?

Comment 2

[Jan Jongboom [:janjongboom] (inactive)]

Yeah, sure, it'll take until later this week though.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Jan Jongboom [:janjongboom] from comment #2)
> Yeah, sure, it'll take until later this week though.

Great, I will try to give you an WIP on bug 964216 first.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Mark this to Sprint 1 so we could could reach v1.4.

Comment 5

[David Flanagan [:djf]]

Tim,

Yes, that seems like a great idea. I'm I didn't read the bug for so long. I've gotten very behind because of 1.3+ blockers.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Clearing target milestone to reflect plan change.

Jan, are you still working on this? If not I will find some time and steal it.

Comment 7

[Jan Jongboom [:janjongboom] (inactive)]

Oh sorry, I forgot about this bug after the 964216 dance. Feel free to steal.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Update: in light to the recent 1.4 stability requirement, this bug should not be landed before 1.4 branches out.

I am resetting assignee so people could take over by that time.