Closed Bug 956186 Opened 11 years ago Closed 11 years ago

Don't use hiddenwindow.html on b2g

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
All
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.3+, firefox27 wontfix, firefox28 fixed, firefox29 fixed, b2g-v1.3 fixed, b2g-v1.3T fixed)

Status:
RESOLVED FIXED
Milestone:
1.3 C2/1.4 S2(17jan)
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox29 --- fixed
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed

People

(Reporter: fabrice, Assigned: fabrice)

Details

Attachments

(1 file)

no-hiddenwindow.patch
1.14 KB, patch
roc
: review+
Details | Diff | Splinter Review
We lose a few hundred K of memory by loading hiddenWindow.html and the associated styles, but we don't need it.
Gregor, feel free to redirect the review, I'm not sure who should take that!
Assignee: nobody → fabrice
Attachment #8355386 - Flags: review?(anygregor)
Whiteboard: [tarako]
Fabrice, will this patch be risky to be uplifted to 1.3 for tarako? Thanks
blocking-b2g: --- → 1.3?
Flags: needinfo?(fabrice)
It is really good to have a small patch to saving hundreds K of memory.
Comment on attachment 8355386 [details] [diff] [review] no-hiddenwindow.patch I don't know this code. Maybe roc knows it?
Attachment #8355386 - Flags: review?(anygregor) → review?(roc)
https://hg.mozilla.org/integration/b2g-inbound/rev/b28b70e9017b
blocking-b2g: 1.3? → 1.3+
Flags: needinfo?(fabrice)
https://hg.mozilla.org/mozilla-central/rev/b28b70e9017b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
status-b2g-v1.3T: --- → fixed
status-b2g-v1.3T: fixed in Tarako branch, remove [tarako] whiteboard
Whiteboard: [tarako]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: