Closed
Bug 95621
Opened 24 years ago
Closed 24 years ago
[Xlib] Sync Xlib fontmetrics with GTK+ fontmetrics
Categories
(Core :: XUL, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla0.9.4
People
(Reporter: roland.mainz, Assigned: roland.mainz)
References
Details
Attachments
(2 files)
4.47 KB,
patch
|
Details | Diff | Splinter Review | |
5.34 KB,
patch
|
Details | Diff | Splinter Review |
RFE: Some fixes+enhancements in GTK+ fontmetrics class needs to be ported to
Xlib fontmetrics, too ...
Assignee | ||
Comment 1•24 years ago
|
||
Reassigning to myself, adding milestone and dependicies...
Assignee | ||
Comment 3•24 years ago
|
||
Assignee | ||
Comment 4•24 years ago
|
||
Assignee | ||
Comment 5•24 years ago
|
||
Requesting r=/sr=
Note that the same code exists already in GTK+ sources - this is only a
copy-to-Xlib-source...
Assignee | ||
Updated•24 years ago
|
Summary: Sync Xlib fontmetrics with GTK+ fontmetrics → [Xlib] Sync Xlib fontmetrics with GTK+ fontmetrics
r=dbaron, since it's porting, although (these comments apply to GTK and Xlib --
could you produce a patch?):
* aFFREName should be |const nsACString&|, not |nsAWritableCString&|
* the nsCStringKey constructed from aFFREName in TryNode should be constructed
without PromiseFlatCString (or .get()), since this code would crash if the
string isn't already flat (although it is).
* in the code that's actually in the patch, you should use NS_LITERAL_CSTRING
to pass the string to TryNode, rather than constructing an nsCAutoString
(expensive) and copying the buffer (expensive)
Comment 9•24 years ago
|
||
May God have mercy on us all. The 212 bug spam-o-rama is Now!
QA Contact: aegis → jrgm
Assignee | ||
Comment 10•24 years ago
|
||
timeless said he'll file a patch for that.
----
Requesting a=drivers (we have r=dbaron, sr=tor) ...
a=roc+moz on behalf of drivers
Assignee | ||
Comment 12•24 years ago
|
||
Please watch patch order:
We have to check-in bug 94569 first ...
Assignee | ||
Comment 13•24 years ago
|
||
Assignee | ||
Comment 14•24 years ago
|
||
2nd attempt to mark it "FIXED" ...
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•