Closed Bug 95621 Opened 24 years ago Closed 24 years ago

[Xlib] Sync Xlib fontmetrics with GTK+ fontmetrics

Categories

(Core :: XUL, enhancement, P3)

All
Linux
enhancement

Tracking

()

RESOLVED FIXED
mozilla0.9.4

People

(Reporter: roland.mainz, Assigned: roland.mainz)

References

Details

Attachments

(2 files)

RFE: Some fixes+enhancements in GTK+ fontmetrics class needs to be ported to Xlib fontmetrics, too ...
Reassigning to myself, adding milestone and dependicies...
Assignee: trudelle → Roland.Mainz
Blocks: 79119
Depends on: 94569
Priority: -- → P3
Target Milestone: --- → mozilla0.9.4
Accepting, patch follows...
Status: NEW → ASSIGNED
Requesting r=/sr= Note that the same code exists already in GTK+ sources - this is only a copy-to-Xlib-source...
sr=tor
Thanks! Looking for r=
Keywords: patch, review
Summary: Sync Xlib fontmetrics with GTK+ fontmetrics → [Xlib] Sync Xlib fontmetrics with GTK+ fontmetrics
r=dbaron, since it's porting, although (these comments apply to GTK and Xlib -- could you produce a patch?): * aFFREName should be |const nsACString&|, not |nsAWritableCString&| * the nsCStringKey constructed from aFFREName in TryNode should be constructed without PromiseFlatCString (or .get()), since this code would crash if the string isn't already flat (although it is). * in the code that's actually in the patch, you should use NS_LITERAL_CSTRING to pass the string to TryNode, rather than constructing an nsCAutoString (expensive) and copying the buffer (expensive)
May God have mercy on us all. The 212 bug spam-o-rama is Now!
QA Contact: aegis → jrgm
timeless said he'll file a patch for that. ---- Requesting a=drivers (we have r=dbaron, sr=tor) ...
Keywords: reviewapproval
Please watch patch order: We have to check-in bug 94569 first ...
2nd attempt to mark it "FIXED" ...
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: