956226 - [buri][fugu][sms] SMS crashes when sharing a picture to message

Status: RESOLVED DUPLICATE of bug 939962

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Peipei Cheng (needinfo if you need my action)]

Environment:
--------------------------
V1.3
Gaia 01e9da49be2cc4bc134eeefc434740d572ec2246
Gecko http://hg.mozilla.org/releases/mozilla-aurora/rev/61f553e5db49
BuildID 20140101004001
Version 28.0a2
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

Reproduce Steps:
--------------------------
0. Prepare a picture with size 200k~300k
1. Launch Gallery
2. Select the picture
3. click share and select "messages"
4. SMS will be launched. Then tap on the picture in MMS body
5. Tap on Home button
6. repeat 1~3

pls see STR video for details: https://mozilla.box.com/s/2cmrvpm9i951kcb17ojy

Actual results:
---------------------------
After step 6 is finished, wait for a while, you will see SMS crashed.

Expected results:
---------------------------
Crash should not happen.

Comment 1

[Julien Wajsberg [:julienw]]

Hey Peipei,

Can you please confirm whether step 4 is really necessary for this STR?

Comment 2

[Peipei Cheng (needinfo if you need my action)]

(In reply to Julien Wajsberg [:julienw] (PTO until January 6th) from comment #1)
> Hey Peipei,
> 
> Can you please confirm whether step 4 is really necessary for this STR?

No, Step 4 is not neccessary. Thanks!

Neccessary steps:
1. Have a pic with size 200k~300k
2. Share the same pic via the same message twice

Comment 3

[Julien Wajsberg [:julienw]]

Thanks!

Can you try this again disabling this pref:

  pref("gfx.canvas.azure.accelerated", false);

I'd like to know whether it's SkiaGL related.

Thanks!

Comment 4

[Peipei Cheng (needinfo if you need my action)]

(In reply to Julien Wajsberg [:julienw] (PTO until January 6th) from comment #3)
> Thanks!
> 
> Can you try this again disabling this pref:
> 
>   pref("gfx.canvas.azure.accelerated", false);
> 
> I'd like to know whether it's SkiaGL related.
> 
> Thanks!

This issue does not happen after disabling the pref you mentioned. Thanks!

Comment 5

[Julien Wajsberg [:julienw]]

Hey Milan,

I think this is part of the SkiaGL work then. Can you please have a look to this bug? Thanks!

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

Is there a stack or a log from the crash?  This is probably the same root cause as bug 941160, but we could use a few more details.

Comment 7

[Milan Sreckovic [:milan] (needinfo for best results)]

(In reply to Milan Sreckovic [:milan] from comment #6)
> Is there a stack or a log from the crash?  This is probably the same root
> cause as bug 941160, but we could use a few more details.

And bug 941160, which was a duplicate of bug 939962, which just landed in central, and is partially uplifted to 1.2/1.3 already.  If this problem does go away, then it's a dupe of 939962.  If it does not, then the work similar to what was done in bug 939962 needs to be done elsewhere in Gaia, probably in the SMS app.  Or it's something completely different :), but hard to tell without the log/stack.

Comment 8

[Julien Wajsberg [:julienw]]

Thanks Milan, the Gaia patch looks easy ;)

Peipei, can you try again with a build from today? It should have the fix in since it landed a few days ago.

Comment 9

[Peipei Cheng (needinfo if you need my action)]

Attachment: 956226.log

I cannot consistently reproduce crash on the latest build. Maybe the crash I saw today is different from what I experienced before.

For the crash today, it only appears the first time I launch SMS & Gallery.

Please see attached adb log. The test start from 01-13 13:44:23.479.

Comment 10

[Julien Wajsberg [:julienw]]

pcheng> some questions for you about comment 9:
* was it a build 1.3 or 1.4 ? Can you try both ?
* was it with "gfx.canvas.azure.accelerated" enabled or disabled ? Can you try both and see if you get the same thing ?
* did you do the STR in comment 2?

Maybe what you're seeing is bug 949202 ?

Thanks!

Comment 11

[Peipei Cheng (needinfo if you need my action)]

The first crash should have been fixed. I think the second one might be sth related to memory. correct me if I'm wrong.

To reproduce the second crash:
1. Share one pic (200k~300k) to messages
2. Tapping on Home button immediately after SMS is launched and new message page appears.
3. Share another pic or the same pic to messages again
   --> SMS is forced to stop. But if you wait for some time before sending SMS to background, everything works fine.

For Julien's questions, please see my comments bellow.

(In reply to Julien Wajsberg [:julienw] from comment #10)
> pcheng> some questions for you about comment 9:
> * was it a build 1.3 or 1.4 ? Can you try both ?

Both v1.3 and v1.4 behave the same.

> * was it with "gfx.canvas.azure.accelerated" enabled or disabled ? Can you
> try both and see if you get the same thing ?

Both case can reproduce the crash mentioned in comment 9. 

> * did you do the STR in comment 2?

Yes. 

> 
> Maybe what you're seeing is bug 949202 ?

It should not because I didn't view the picture. 

> 
> Thanks!

Comment 12

[Julien Wajsberg [:julienw]]

pcheng, a last question for you: does it happen with a bigger pic (eg: 400k or 500k) ?

Comment 13

[Peipei Cheng (needinfo if you need my action)]

(In reply to Julien Wajsberg [:julienw] from comment #12)
> pcheng, a last question for you: does it happen with a bigger pic (eg: 400k
> or 500k) ?

I tried again with a bigger pic. The behavior is similar but worse if I send SMS to background before resizing finish. A white screen appears and device has no response after resend pic to messages. It should be caused by the same reason.

Comment 14

[Julien Wajsberg [:julienw]]

Ok thanks !

So the comment 0 was fixed by bug 939962, but I'd like to close the STR from comment 11 here.

Jerry, would you have some time to help with getting and analyzing the memory patterns of the STR in comment 11?

Comment 15

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi Peipei,

Did you test and get crash multiple times? I see a lot of ipc error in log(attachment 8359050 [details]).
I'm working on another 1.3+ blocking problem. I can do this work, but I need to finish the 1.3+ problem first.
Keep needinfo for reminder.

Comment 16

[Jason Smith [:jsmith]]

Given that comment 0 was fixed by bug 939962, I'm closing this as a dupe. If there's something else being analyzed here, then let's get a separate bug filed focusing on that problem.

Comment 17

[Julien Wajsberg [:julienw]]

Jerry, moving your need info to bug 959422.