956260 - Decrease the browser window's minimum width in pre-Australis Firefox

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Dão Gottwald [:dao]]

Bug 897160 set a minimum width on the browser window based on Australis constraints, but landed it in pre-Australis Firefox where the used width is over-zealous and users are understandably complaining about it.

Bug 897160 comment 61 suggests that 250 would be a reasonable value to adopt. I think we should do this on Beta, Aurora and the Holly branch.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8355495 [details] [diff] [review]
patch

Review of attachment 8355495 [details] [diff] [review]:
-----------------------------------------------------------------

We could do this on Aurora and Beta, but I'd rather not do it on Holly because it touches browser/base/content/browser.css and that can make future merges more difficult.

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8355495 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 897160
User impact if declined: see comment 0
Testing completed (on m-c, etc.): this patch is only for aurora & beta
Risk to taking this patch (and alternatives if risky): no risk
String or IDL/UUID changes made by this patch: none

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/10dd4e9b13fb
https://hg.mozilla.org/releases/mozilla-beta/rev/2fb364c9bfd1

I'm assuming Australis will ship in 29. If it doesn't, we can reopen this and change the status accordingly.

Comment 5

[Kohei Yoshino [:kohei]]

Updated the compat doc accordingly.
https://developer.mozilla.org/en-US/Firefox/Releases/26/Site_Compatibility

Comment 6

[u279076]

Henrik, given in-testsuite-, I'm wondering if this is something we should be testing in-qa-testsuite?

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Anthony Hughes, QA Mentor (:ashughes) from comment #6)
> Henrik, given in-testsuite-, I'm wondering if this is something we should be
> testing in-qa-testsuite?

Given the lack of a comment I have no idea why in-testsuite has been denied. I would like to get further information from Dao first.

Comment 8

[Dão Gottwald [:dao]]

There was no comment when setting in-testsuite? either. What kind of automated test did you have in mind?

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Forwarding this question to Anthony then...

Comment 10

[u279076]

(In reply to Dão Gottwald [:dao] from comment #8)
> There was no comment when setting in-testsuite? either. What kind of
> automated test did you have in mind?

I'm not sure what framework is appropriate but something to ensure the minimum bounds are being respected.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Removing my name from in-qa-testsuite flag for a better query.