956384 - Enable addons for talos runs when running metro browser

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jordan Lund (:jlund)]

looks like metro talos runs have been failing since: 
https://tbpl.mozilla.org/?tree=Cedar&jobname=svgr-metro&rev=5dc615915eb6

There was a patch in that disabled addon providers in metro:
https://hg.mozilla.org/projects/cedar/rev/c237f02b3578

We should disable addons for metro talos runs.

This was a fix in mozprofile to enable addons. Not sure if talos uses mozprofile though:
https://github.com/mozilla/mozbase/commit/d4d704f3b0c3202646e2078bd54cf49afab7f65c

Comment 1

[Jordan Lund (:jlund)]

sorry for confusion --

> There was a patch in that disabled addon providers in metro:
> https://hg.mozilla.org/projects/cedar/rev/c237f02b3578

edit: There was a patch that added a pref to completely disable add-on providers in Metro

> We should disable add-ons for metro talos runs.

edit: We should *enable* add-ons for metro talos runs.

Comment 2

[Jordan Lund (:jlund)]

Attachment: 956384_enable_addons_for_metro_talos.060114.diff

This ensures that addons are enabled for every talos run while fixing the related metro failures.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8356419 [details] [diff] [review]
956384_enable_addons_for_metro_talos.060114.diff

Review of attachment 8356419 [details] [diff] [review]:
-----------------------------------------------------------------

::: talos/PerfConfigurator.py
@@ +237,5 @@
>          'browser.shell.checkDefaultBrowser': False,
>          'browser.warnOnQuit': False,
>          'browser.display.overlaynavbuttons': False, # metrofx specific
> +        # Bug 956384 - Enable addons for metro browser
> +        'extensions.defaultProviders.enabled': True,  # metrofx specific

double checking- this preference does not affect non metro tests?

Comment 4

[Jordan Lund (:jlund)]

Attachment: 956384_enable_addons_for_metro_talos-inbound-080114.diff

As per IRC discussion regarding the unknown performance implications of making a talos wide change, we will only add this pref for metro runs via CLI so we can resolve this bug. Then we can re-add it talos wide across every platform over one branch until we have more data.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8357256 [details] [diff] [review]
956384_enable_addons_for_metro_talos-inbound-080114.diff

Review of attachment 8357256 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/talos/talos.json
@@ +69,5 @@
>          "dromaeojs-metro": {
>              "tests": ["dromaeo_css", "dromaeo_dom", "kraken", "v8_7"],
> +            "metro_mode": true,
> +            "talos_options": [
> +                "--setPref", "extensions.defaultProviders.enabled=True"

these should be lowercase, s/True/true/

Comment 6

[Jordan Lund (:jlund)]

pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/7a57d633a163

w/ lowercase 'true'

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7a57d633a163