956385 - SimpleTest.monitorConsole counts non-matching messages towards the total

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Bobby Holley (:bholley)]

SimpleTest.monitorConsole is a nice mechanism that allows consumers to check for an expected series of console messages. It optionally allows consumers to force a test failure of a console message is received, but this is understandably not the default, since it increases the chance of breakage when unrelated console warning are added (i.e. for deprecated web features).

In the default case, unexpected console messages are just ignored (that is to say: failures of the regexp do not cause the test to fail). However, they _still_ increment the counter of expected messages, which is totally wrong. In the current world, a test which does not get the message it expects, but gets a totally unrelated message (say, a syntax error), will pass, when it should definitely fail.

I have a patch for this. Pushing to try momentarily.

Comment 1

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=19a51c60748c

Comment 2

[(not currently active) Ted Mielczarek]

Drew did a rewrite of this in bug 898593. We discussed it a little bit there, but we probably just missed this corner case. Thanks for filing the bug (and hacking on it).

Comment 3

[Bobby Holley (:bholley)]

Attachment: Don't count non-matching messages toward the total. v1

This looks green. Flagging ted for review.

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/524b810fa489