956420 - header on Twitter scrolls incorrectly when viewing images

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: header.mp4

see screenshot. not sure if its fixed position or not, regardless its not right.

Comment 1

[Aaron Train [:aaronmt]]

Steps: https://twitter.com/firefox/status/416976893259182080 and then tap the image.

Testing on my Nexus 5 it doesn't look as bad as is on your device, see video: http://www.youtube.com/watch?v=QzmCr7sbyTs

There's a small gap above the header between the URL-bar and the header still.

Behaviour is different on all channels.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Did bug 940889 regress this at all? Just wondering if we should block that from getting uplifted.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I don't believe bug 940889 is responsible here. I'm also not able to reproduce the issue in comment 0. I can see the issue in comment 1; this appears to be the fixed-position bar lagging a little bit as you scroll.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

I'll try to get a testcase

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

I see the same behavior on SUMO with the Nexus One, however I can't get a screencast from the Nexus One and the screen on the Nexus 5 is too big for it to be pannable.

Comment 7

[Chris Lord [:cwiiis]]

I think this is a regression, can we get a range?

Comment 8

[Chris Lord [:cwiiis]]

Attachment: Fix fixed margins on short pages

Not sure how this one slipped through... Could've sworn I tested this exact scenario, but obviously not (unless it regressed at some point).

Comment 9

[Chris Lord [:cwiiis]]

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/b1ea2300010c

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b1ea2300010c

Comment 11

[Ioana Chiorean]

As per the fix and IRC discussion this is not needed anymore.

Comment 12

[Chris Lord [:cwiiis]]

Comment on attachment 8360443 [details] [diff] [review]
Fix fixed margins on short pages

[Approval Request Comment]
Bug caused by (feature/regressing bug #): This bug
User impact if declined: Weird fixed header behaviour on Twitter (and any site that causes a pinned toolbar)
Testing completed (on m-c, etc.): Tested locally and now on m-c
Risk to taking this patch (and alternatives if risky): Low risk
String or IDL/UUID changes made by this patch: None

Given that Twitter is pretty popular(!), we should probably uplift this patch. I consider it to be pretty low risk.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 8360443 [details] [diff] [review]
Fix fixed margins on short pages

Yes, Twitter is pretty popular and this looks very low risk so let's land today and get this into our second-to-last mobile beta.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b4730eb549e8
https://hg.mozilla.org/releases/mozilla-beta/rev/ca8ea758fb17