956422 - check for lessc during make and bail if its not there

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Selena Deckelmann :selenamarie :selena]

User was on version 70.

Not sure what the right way is to fix this: 


14:19 <       Keith> | getting this error: "Compressing... Error: An error occured during rendering /home/ec2-user/socorro/webapp-django/crashstats/crashstats/templates/crashstats/gccrashes.html: 
          /bin/sh: lessc: command not found"
14:19 <       Keith> | but lessc is in my path. Any suggestions?
14:20 < selenamarie> hrm. i wonder if make sets up a separate npm install
14:20   selenamarie looks at the makefile
14:20 [notice(qatestbot:#breakpad)] Yippee, build fixed!
14:20 [notice(qatestbot:#breakpad)] Project socorro.stage.saucelabs build #669: FIXED in 8 min 22 sec: http://qa-selenium.mv.mozilla.com:8080/job/socorro.stage.saucelabs/669/
14:21 < selenamarie> Keith: so 'make bootsrap' does this: 
14:21 < selenamarie>     PATH=$$PATH:node_modules/.bin which lessc || npm install less
14:21 < selenamarie> so in theory if the user running 'make install' has a $PATH that's ok it /should/ work
14:21 <       Keith> | this is my path: 
/home/ec2-user/socorro/socorro-virtualenv/bin:node_modules/.bin/:/opt/centos/devtoolset-1.1/root/usr/bin:/usr/lib64/qt-3.3/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/ec2-user/bin:/usr/pgsql-9.3/bin/
14:21 < selenamarie> Keith: what user are you running make install as? 
14:21 <       Keith> | I am running as my ec2-user
14:22 < selenamarie> and what's the output of 'which lessc'? 
14:22 <       Keith> | ~/socorro/node_modules/.bin/lessc
14:23 <       Keith> | looks like there are two lessc -  both are the same version
14:23 <       Keith> | (socorro-virtualenv)[ec2-user@ip-10-252-46-91 ~]$ ./socorro/node_modules/less/bin/lessc -v
14:23 <       Keith> | lessc 1.6.0 (LESS Compiler) [JavaScript]
14:23 <       Keith> | (socorro-virtualenv)[ec2-user@ip-10-252-46-91 ~]$ ./socorro/node_modules/.bin/lessc -v
14:23 <       Keith> | lessc 1.6.0 (LESS Compiler) [JavaScript]
14:24 < selenamarie> hrmph
14:24 <       Keith> | I can reproduce the failure just running /manage.py compress_jingo --force
14:24 <       Keith> | and the first error is : "Invalid template /home/ec2-user/socorro/webapp-django/vendor/lib/python/djcelery/templates/djcelery/confirm_rate_limit.html: Encountered unknown tag 
          'load'."
14:25 < selenamarie> hrmph. what if we update your path before you run make install to: 
14:25 < selenamarie> /home/ec2-user/socorro/socorro-virtualenv/bin:node_modules/.bin/:/opt/centos/devtoolset-1.1/root/usr/bin:/usr/lib64/qt-3.3/bin:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/sbin:/home/ec2-user/bin:/usr/pgsql-9.3/bin:~/socorro/node_modules/.bin
14:25 < selenamarie> (just to rule that out)
14:25 <       Keith> | ok
14:26 <       Keith> | I'm trying to build version 70 - is there a different branch I should try?
14:27 < selenamarie> no, lessc just sucks :D
14:27 <       Keith> | Hey! That fixed it
14:27 <       Keith> | THANKS!

Comment 1

[Robert Helmer [:rhelmer]]

I kind of think we should just detect that lessc is not on the PATH and bail out, and not bother trying to install it. We can list the RPM and deb as required in our install docs, and let anyone that wants to install it otherwise do their own npm wrangling.

Comment 2

[Peter Bengtsson [:peterbe]]

(In reply to Robert Helmer [:rhelmer] from comment #1)
> I kind of think we should just detect that lessc is not on the PATH and bail
> out, and not bother trying to install it. We can list the RPM and deb as
> required in our install docs, and let anyone that wants to install it
> otherwise do their own npm wrangling.

+1 on that. 
I didn't even know that we "force" install it.

Comment 3

[Peter Bengtsson [:peterbe]]

By the way,

  "Invalid template /home/ec2-user/socorro/webapp-django/vendor/lib/python/djcelery/templates/djcelery/confirm_rate_limit.html: Encountered unknown tag 
          'load'."

Is actually only a harmless warning. Annoying, but harmless.

Comment 4

[Lonnen :lonnen]

:+1:, waiting to merge until after this week's release

Comment 5

[Lonnen :lonnen]

fixed in https://github.com/mozilla/socorro/commit/39f3c1d1fdaa6661dc9995562f8dc1f028e68cca