956443 - Include Firefox version in Android client records

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Richard Newman [:rnewman]]

See Bug 956442 for desktop.

Comment 1

[Richard Newman [:rnewman]]

https://github.com/mozilla-services/android-sync/pull/379

Comment 2

[Nick Alexander :nalexander [he/him]]

When I think about this, I want some "human readable" version (which could be the User-Agent string?) and some "machine readable" version (which is defined at compile time).  I also don't see where the version is getting set in the above commit.

Comment 3

[Richard Newman [:rnewman]]

(In reply to Nick Alexander :nalexander from comment #2)
> When I think about this, I want some "human readable" version (which could
> be the User-Agent string?) and some "machine readable" version (which is
> defined at compile time).

I suspect the UA is even less readable than the machine-readable version, but I think what you're saying is:

  "ver": "27.0a1",
  "version": "Firefox Aurora 27"

right?

> I also don't see where the version is getting set
> in the above commit.

Hah, that's because I didn't save the file. It's like failing to qref, but even more failicious.

Comment 4

[Richard Newman [:rnewman]]

This, plus Bug 956442, plus debugging:

https://tbpl.mozilla.org/?tree=Try&rev=434cc23b365a

My plan is to grab Mac and Android builds for manual QA, in addition to the tests.

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: github PR

nits for documentation, r=nalexander.  Would love to get this to QA ASAP.

Comment 6

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/1720e3409e72

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1720e3409e72

Comment 8

[Richard Newman [:rnewman]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0c0281672c11

Comment 9

[Richard Newman [:rnewman]]

https://hg.mozilla.org/releases/mozilla-beta/rev/33a946393682