956454 - [B2G][Settings][SIM Security] SIM Security menu is unable when toggle Airplane mode on/off

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[sarsenyev]

Attachment: 2014-01-03-17-17-19.png

Description:
SIM Security menu is grayed out and unable when switching "Airplane mode" on and then off when a SIM PIN is previously set on

Prerequisites:
SIM PIN is set on the device

Repro Steps:
1) Updated Buri to BuildID: 20140103004001
2) Go to "Settings" from the home screen
3) Toggle "Airplane mode " on and then off
4) Observe the "Security PIN" menu
5) Press the "Power" button twice
6) When the "SIM passcode" screen opens type a correct PIN code
7) Observe the "Security PIN" menu 

Actual:
The SIM Security menu is grayed out and not available 

Expected:
When the SIM PIN is enabled the settings info shows "Enabled"
When the SIM PIN is disabled the settings info shows "Disabled"

Environmental Variables:
Device: Buri 1.3 COM
BuildID: 20140103004001
Gaia: ae7d05689b6b9ac4ec6182217dfdef06be28e886
Gecko: d9226a660d52
Version: 28.0a2
RIL Version: 01.02.00.019.102
Firmware Version: v1.2_20131115

Notes:
Repro frequency: 100%
See attached: video clip

Comment 1

[Jason Smith [:jsmith]]

Does this reproduce on 1.2?

Comment 2

[sarsenyev]

It doesn't reproduce on the latest 1.2
"SIM Security" doesn't gray out when airplane mode is on, just a message is changed for "SIM card not ready"

Device: Buri 1.2 MOZ
BuildID: 20140106004001
Gaia: 8441587c3b352e052fee07665c21fd192540f19f
Gecko: d552c08a72d0
Version: 26.0
Firmware Version: v1.2_20131115

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Triage: regression

EJ, this is caused by the bug you are fixing right now? Could you dup this if your patch on that bug fix this issue?

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Jose, 

I checked the code in settings.js about this part and it seems that this bug is related to bug 928297.

I asked Arthur about that bug and it seems that you had a refactor plan about it. (which is also related to this bug)

Any further news/ideas about it ?

Thanks :)

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Confirming regression. Jose, could you either provide a quick fix to this bug or roll your refactor plan (bug ?) to 1.3?

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Too many changes have been added to the setting app due the support added for multi ICC card devices. Bug 945150 is about disabling/enabling the menu items (such as call setting, cellular an data, SIM security, etc) in the root panel correctly so I'll handle this issue in bug 945150. See https://bugzilla.mozilla.org/show_bug.cgi?id=945150#c14 for more information about what is going on bug 945150 please. Should we resolve (somehow) this bug as a duplicate of bug 945150?

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Update based on comment 6.

Thanks José!

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Bug already landed 945150 so this issue should not happen. I'll request QA to verify it.

Comment 9

[sarsenyev]

Yes, the fix is landed on master build,
So it doesn't reproduce on master build 1.4
"SIM Security" option is accessible after entering a correct SIM PIN

Device: Buri 1.4 MOZ
BuildID: 20140117041037
Gaia: ef8bb31b462f364b57432a0724c78034d3f4f303
Gecko: b53589696cf8
Version: 29.0a1
Firmware Version: v1.2-device.cfg

Comment 10

[Jason Smith [:jsmith]]

Marking fixed then & leaving 1.3 affected until the dependency gets uplifted.