956488 - Add separators to menu panel footer

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[u428464]

As seen on the Win 8 mockup : http://people.mozilla.org/~shorlander/mockups-interactive/australis-interactive-mockups/windows8.html there should be separators between the Customize/Help/Quit buttons

Comment 1

[u428464]

The size and colour of the footer could also be changed to better match the mockup.

Comment 2

[Darrin Henein [:darrin]]

Attachment: menu-footer-separators.patch v1

Had to refactor some of the CSS to get the hover states working correctly.

Comment 3

[Mike de Boer [:mikedeboer]]

Comment on attachment 8362679 [details] [diff] [review]
menu-footer-separators.patch v1

Review of attachment 8362679 [details] [diff] [review]:
-----------------------------------------------------------------

Darrin, thanks for working on this!

I have one comment, which is the reason for the r-. Can you post the patch that fixes this?

All the other changes look good to me!

What is your current commit access level?

::: browser/themes/shared/customizableui/panelUIOverlay.inc.css
@@ +199,5 @@
>    margin: 0;
>    min-height: 4em;
>  }
>  
> +#PanelUI-footer toolbarseparator {

Please use child selectors (`#PanelUI-footer > toolbarseparator`)

Comment 4

[Darrin Henein [:darrin]]

Attachment: menu-footer-separators.patch v2

Added child selectors.

Comment 5

[Mike de Boer [:mikedeboer]]

Comment on attachment 8363674 [details] [diff] [review]
menu-footer-separators.patch v2

Review of attachment 8363674 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks Darrin!

Comment 6

[Mike de Boer [:mikedeboer]]

remote: https://hg.mozilla.org/integration/fx-team/rev/f959b4153085

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f959b4153085