956624 - Try valgrind jobs coalesce when they shouldn't

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[Nick Thomas [:nthomas] (UTC+12)]

http://hg.mozilla.org/try/pushloghtml?fromchange=387e2dbf898b&tochange=2be0fc2f13a8 has pushes at 17:35:25 (daf17073da76) and 17:35:57 (2be0fc2f13a8) today. The poller came along at 17:36:53 and added them to the scheduler db with separate sourcestamps, buildsets buildrequests etc.

When the jobs ran they got combined into a single job with both changes
http://buildbot-master87.srv.releng.scl3.mozilla.com:8101/builders/Linux%20x86-64%20try%20valgrind/builds/173

This may only happen for changes with the same author, or it might just require two pushes in less than 60 seconds (but should have heard already in this case), or valgrind isn't being treated right.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Looks like a valgrind specific issue, the builder never gets added to the nomergeBuilders list.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbotcustom] Add valgrind name to list of builders

... so that http://hg.mozilla.org/build/buildbotcustom/file/default/misc.py#l999 can do its thing. Also double checked that nothing else needs this on try.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8356016 [details] [diff] [review]
[buildbotcustom] Add valgrind name to list of builders

https://hg.mozilla.org/build/buildbotcustom/rev/b7cf19f1b3cc

This should get deployed tomorrow morning.

Comment 4

[Armen [:armenzg]]

In production (not CCed).