Closed
Bug 956626
Opened 11 years ago
Closed 11 years ago
Button doesn't like add-on IDs with dots
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jryans, Assigned: jryans)
References
Details
Attachments
(1 file)
ui/button/view.js creates a buttonPrefix from the add-on ID, which is then passed into CustomizableUI as the widget ID. However, "." is not allowed in a widget ID, so these should be converted to "-dot-" as they are in resource paths.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8355987 -
Flags: review?(zer0)
|
||
Updated•11 years ago
|
Priority: -- → P1
|
||
Comment 3•11 years ago
|
||
I just comment the PR: it could be better if we can cover all the scenarios and uniform the code with the toolbar's one.
|
|
Assignee | |
Comment 4•11 years ago
|
||
Updated the PR as suggested.
|
|
||
Updated•11 years ago
|
Attachment #8355987 -
Flags: review?(zer0) → review+
|
||
Comment 5•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/f8d0410bae6a0193e6ed882a08121d82538f8602
Bug 956626 - Convert periods to text in widget IDs. r=zer0
https://github.com/mozilla/addon-sdk/commit/b7b11bad726c16a3e906f66a29b4208cc71e03e2
Merge pull request #1333 from jryans/button-view-id
fix Bug 956626 - Convert periods to text in widget IDs r=@ZER0
|
|
||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•