956626 - Button doesn't like add-on IDs with dots

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

ui/button/view.js creates a buttonPrefix from the add-on ID, which is then passed into CustomizableUI as the widget ID.  However, "." is not allowed in a widget ID, so these should be converted to "-dot-" as they are in resource paths.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Convert periods to text in widget IDs

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

I just comment the PR: it could be better if we can cover all the scenarios and uniform the code with the toolbar's one.

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Updated the PR as suggested.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/f8d0410bae6a0193e6ed882a08121d82538f8602
Bug 956626 - Convert periods to text in widget IDs. r=zer0

https://github.com/mozilla/addon-sdk/commit/b7b11bad726c16a3e906f66a29b4208cc71e03e2
Merge pull request #1333 from jryans/button-view-id

fix Bug 956626 - Convert periods to text in widget IDs r=@ZER0