Closed Bug 956645 Opened 6 years ago Closed 6 years ago

The strings for the source editor's context menu aren't consistently capitalized like in other menu items

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 29

People

(Reporter: vporof, Assigned: alexey.novak.mail)

Details

(Whiteboard: [good first bug][lang=text][mentor=vporof])

Attachments

(1 file, 3 obsolete files)

In Firefox at least, it seems that the de-facto capitalization scheme for menu items is "Something Like This". The editor's context menu in the debugger is the only one not respecting this scheme. Let's be consistent
Priority: -- → P3
This one is very easy to fix. Some strings just need to be capitalized properly.
Whiteboard: [good first bug][lang=text][mentor=vporof]
Hi there.
I would love to take care of this bug; it does look super easy. Correct me if I'm wrong but it is only a change in debugger.dtd file
Hi Alexey! Yes, that's the only thing you need to do, modify some stuff in the debugger.dtd file. You won't need to change the identifiers, because the meaning of the strings hasn't changed, only the capitalization.

Just go through all the strings and Capitalize Like This the ones which appear in menus or context menus.
Assignee: nobody → alexey.novak.mail
Status: NEW → ASSIGNED
Attached patch 956645.patch (obsolete) — Splinter Review
Hi Victor,

Thanks a lot for such a quick reply.
I did some changes in debugger.dtd which are related to the context menus. Also noticed there are couple of tooltips and labels for checkboxes. I wanted to double check with you before making any changes if I need to change them as well ?

Another question - what is the rule about prepositions, conjunctions and prepositions? Are they capitalized?
I found a string "Edit As HTML" in Inspector but at the same time I found "Open URL in New Tab" in Profiler.
In my patch I capitalized (example "Search in all files" became "Search In All Files")

Also some of my observations:
I noticed that Sources section in Debugger tab also has "non-proper capitalized" strings in the context menu. You need to add a breakpoint in the code and then right-click on it in the Sources section to see them.

I also noticed that the same problem could be found in Rules of Inspector tab when you right click in the rules area.

Style editor has a line "Jump to line..." when you right click in the area. Or "Show original sources" when you right click on any of the <inline sheet #N> items on the left side (my apologize, I do not know a proper name for it)

It probably would be a good idea to go through all of the existing context menus in dev tools and find inconsistencies in strings.
Attachment #8368366 - Flags: review?(vporof)
I think the proper capitalization is "Edit as HTML", but that's a different bug and we shouldn't take care of it here. We should use "Search in All Files", "Search for Function Definition" and similar to all strings in the debugger that appear in menus.

If you feel that it's a good idea, please file a bug about having consistent capitalization in all our menus. Let's deal with the debugger in this bug.

Here's a neat tool you could use http://titlecapitalization.com/

Please update the patch and I'll r+ it in a heardbeat ;) Thanks!
Besides heardbeats, I'll also r+ in a heartbeat.
Attachment #8368366 - Flags: review?(vporof)
Attached patch 956645.2.patch (obsolete) — Splinter Review
That is one VERY useful link. I saved it in my bookmarks for the future use and for the future generations :)

Also fixed my patch. Please take a look.

From your reply I assume that tooltips and checkbox labels are staying unchanged in debugger.dtd

I think that having the same consistent menus across all tabs in dev tools would be a good idea. Will create a new ticket for this.


"Waiting for the Patch to Land in Fx-Team"
Attachment #8368366 - Attachment is obsolete: true
Attachment #8368719 - Flags: review?(vporof)
Comment on attachment 8368719 [details] [diff] [review]
956645.2.patch

Review of attachment 8368719 [details] [diff] [review]:
-----------------------------------------------------------------

This looks very good! There are a few more strings that you should capitalize before landing it, but great work so far.
In the debugger, there's a "cog wheel" menu on the far right, in the toolbar. There are some strings there, like "Pause on exceptions", "Ignore caught exceptions" and others, that should be capitalized as well.
Attachment #8368719 - Flags: review?(vporof) → feedback+
Attached patch 956645.3.patch (obsolete) — Splinter Review
So this is what those checkbox labels are..

Fixed.

Please let me know if there is anything else I need to change.
Attachment #8368719 - Attachment is obsolete: true
Attachment #8368905 - Flags: review?(vporof)
Attached patch 956645.4.patchSplinter Review
Missed few things...
Attachment #8368905 - Attachment is obsolete: true
Attachment #8368905 - Flags: review?(vporof)
Attachment #8368928 - Flags: review?(vporof)
Comment on attachment 8368928 [details] [diff] [review]
956645.4.patch

Review of attachment 8368928 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!
Attachment #8368928 - Flags: review?(vporof) → review+
https://hg.mozilla.org/integration/fx-team/rev/6a6aaf1887fe
Whiteboard: [good first bug][lang=text][mentor=vporof] → [good first bug][lang=text][mentor=vporof][fixed-in-fx-team]
I just realized that I completely messed the commit message for this patch :S
It should be "Bug 956645: Making proper capitalized strings in source editor's context menus; r=vp"

My bad.
Flags: needinfo?(vporof)
No worries, I changed it before landing.
Flags: needinfo?(vporof)
Ugh no idea how I managed to copy paste that :S

Thanks a lot for being so responsive and helpful! Mentor award 2014 on its way.

If you have any other bugs (more complex as well) need resolving and mentoring I can always take a look at them.
Thank *you* for contributing ;) Here's a link for getting involved if you're interested: https://wiki.mozilla.org/DevTools/GetInvolved#Mentored_and_Good_First_Bugs
https://hg.mozilla.org/mozilla-central/rev/6a6aaf1887fe
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=text][mentor=vporof][fixed-in-fx-team] → [good first bug][lang=text][mentor=vporof]
Target Milestone: --- → Firefox 29
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.