"I have lost my other device" link fails

RESOLVED WONTFIX

Status

Cloud Services
Firefox Sync: UI
RESOLVED WONTFIX
4 years ago
4 years ago

People

(Reporter: markh, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

(Reporter)

Description

4 years ago
Since fxaccounts etc landed, if you have *not* enabled fxaccounts:

* from "setup sync" select "I have an Account" - "pair a device" ui shows.
* from the "pair" ui, select "I don't have the device with me" - a "sign in" page appears.
* from the "sign in" ui, select "I have lost my other device".

Console reports:
 JavaScript error: resource://services-sync/identity.js, line 260: Error: syncKey cannot be set before username.

and no additional UI is displayed.
Blocks: 905997
Whiteboard: [qa+]
(Reporter)

Comment 1

4 years ago
hrmph - I can reproduce this on 25 and later testing with a clean profile - so this has nothing to do with browserid_identity landing!
No longer blocks: 949259
+ some Sync Dev
(Reporter)

Comment 3

4 years ago
The problem here is that in the STR, the username and password have not been filled in.  Then, when the link is clicked, resetPassphrase() in sync/setup.js generates a new key, but setting it fails as the account name is blank.

So it seems this is more of a UX issue with the setup panel than a "real" bug (ie, clicking the link should display an appropriate message in this case).  I'll leave it to the sync devs to decide how to move forward here.
Yeah, gSyncSetup.resetPassphrase will only work if the user has already entered a username and password. It'll error if they haven't.

We should probably hide the entire Recovery Key section until they've entered a valid username and password, or something like that.

Notably, even if you fill in the fields in order, we also show a yellow bar in the background ("Wrong Recovery Key") as we're in the middle of the initial sync.

I told you this UI sucked, didn't I?
(In reply to Mark Hammond [:markh] from comment #3)
> I'll leave it to the sync devs to decide how to move forward here.

You know that there are no Sync devs, right? That team was disbanded more than a year ago, and the entire product abandoned. ORGANIZATIONAL FAIL.
(Reporter)

Comment 6

4 years ago
(In reply to Richard Newman [:rnewman] from comment #5)
> You know that there are no Sync devs, right?

Yeah, but "sync suckers" seemed a little too harsh ;) ;)
(In reply to Mark Hammond [:markh] from comment #6)
> (In reply to Richard Newman [:rnewman] from comment #5)
> > You know that there are no Sync devs, right?
> 
> Yeah, but "sync suckers" seemed a little too harsh ;) ;)

Oh, we're used to it :D
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
Can you guys drop a reason in here please, before I Verify it?
Thanks.
In short: reworking this UI is too painful to take on. The Sync code is only able to reset your passphrase if it has your other credentials.
(Reporter)

Comment 10

4 years ago
To clarify: this only affects "legacy" sync and isn't related to fxa
You need to log in before you can comment on or make changes to this bug.