hrmph - I can reproduce this on 25 and later testing with a clean profile - so this has nothing to do with browserid_identity landing!
+ some Sync Dev
The problem here is that in the STR, the username and password have not been filled in. Then, when the link is clicked, resetPassphrase() in sync/setup.js generates a new key, but setting it fails as the account name is blank. So it seems this is more of a UX issue with the setup panel than a "real" bug (ie, clicking the link should display an appropriate message in this case). I'll leave it to the sync devs to decide how to move forward here.
Yeah, gSyncSetup.resetPassphrase will only work if the user has already entered a username and password. It'll error if they haven't. We should probably hide the entire Recovery Key section until they've entered a valid username and password, or something like that. Notably, even if you fill in the fields in order, we also show a yellow bar in the background ("Wrong Recovery Key") as we're in the middle of the initial sync. I told you this UI sucked, didn't I?
(In reply to Mark Hammond [:markh] from comment #3) > I'll leave it to the sync devs to decide how to move forward here. You know that there are no Sync devs, right? That team was disbanded more than a year ago, and the entire product abandoned. ORGANIZATIONAL FAIL.
(In reply to Richard Newman [:rnewman] from comment #5) > You know that there are no Sync devs, right? Yeah, but "sync suckers" seemed a little too harsh ;) ;)
(In reply to Mark Hammond [:markh] from comment #6) > (In reply to Richard Newman [:rnewman] from comment #5) > > You know that there are no Sync devs, right? > > Yeah, but "sync suckers" seemed a little too harsh ;) ;) Oh, we're used to it :D
Can you guys drop a reason in here please, before I Verify it? Thanks.
In short: reworking this UI is too painful to take on. The Sync code is only able to reset your passphrase if it has your other credentials.
To clarify: this only affects "legacy" sync and isn't related to fxa