956679 - DroidSansThai.ttf is not found in gonk-kk

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: make a local copy of DroidSansThai.ttf

DroidSansThai.ttf is not found in gonk-kk, without this Thai language can't be displayed correctly. I think we can make a local copy from jb.

Comment 1

[Michael Wu [:mwu]]

FWIW - Droid Sans Thai was removed in kitkat since Android decided to use Noto Sans. See https://android.googlesource.com/platform/frameworks/base/+/531dfc45735eb0f1c5a452747b9261a0a6d2f182 .

This PR will make us continue to use Droid Sans Thai, but I wonder if Noto Sans might be better for this purpose. At any rate, we should merge this to support kitkat.

Comment 2

[Jonathan Kew [:jfkthame]]

Looks to me like the Thai glyphs in Noto are simply copied from the older Droid Sans font. However, the Noto repository also has a Bold weight, whereas AFAIK there was only a Regular weight of Droid Sans Thai.

I suppose going forward, it may be more likely Google will maintain/enhance the Noto version, as that's where they're focusing efforts these days. So adopting this in Gonk as well may be preferable. All that should require is replacing the font itself, and changing the default names in gfx/thebes/gfxAndroidPlatform.cpp and modules/libpref/src/init/all.js.

In particular, if we're [going to be] shipping in the Thai market it'd be nice to switch to the Noto version of the font with its real Bold face.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/moztt/commit/96d2d00165f4561fbde62d1062706eab74b3a01f