956782 - Swap Search and Share in Text-Selection Action Bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul [pwd]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140103050744

Steps to reproduce:

Search is an inline action where as Share takes you out of the app, thus Search should be grouped with the rest of the inline actions while Share should be moved to the end of the row.

Comment 1

[Aaron Train [:aaronmt]]

Agreed!

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Ian, what do you want to do here?

Comment 3

[Ian Barlow (:ibarlow)]

I am fine to switch them

Comment 4

[Aaron Train [:aaronmt]]

During triage Wes mentioned he has a patch somewhere with this I think

Comment 5

[Wesley Johnston (:wesj)]

Attachment: Patch v1

This puts a pretty explicit order in here. Hard to edit later, but nice to be explicit. We can do something easier if you want (i.e. just change the search action).

Comment 6

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/5e1c5e7785aa

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5e1c5e7785aa