Swap Search and Share in Text-Selection Action Bar

VERIFIED FIXED in Firefox 29

Status

()

Firefox for Android
General
VERIFIED FIXED
4 years ago
2 years ago

People

(Reporter: Paul [pwd], Assigned: wesj)

Tracking

Trunk
Firefox 29
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox29 verified, fennec28+)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140103050744

Steps to reproduce:

Search is an inline action where as Share takes you out of the app, thus Search should be grouped with the rest of the inline actions while Share should be moved to the end of the row.
(Reporter)

Updated

4 years ago
Blocks: 952112, 768667
OS: Linux → Android
Hardware: x86 → ARM
Agreed!

Updated

4 years ago
tracking-fennec: --- → ?
Ian, what do you want to do here?
Flags: needinfo?(ibarlow)
I am fine to switch them
Flags: needinfo?(ibarlow)
During triage Wes mentioned he has a patch somewhere with this I think
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Updated

4 years ago
Flags: needinfo?(wjohnston)
(Assignee)

Comment 5

4 years ago
Created attachment 8360633 [details] [diff] [review]
Patch v1

This puts a pretty explicit order in here. Hard to edit later, but nice to be explicit. We can do something easier if you want (i.e. just change the search action).
Attachment #8360633 - Flags: review?(mark.finkle)
Flags: needinfo?(wjohnston)
Attachment #8360633 - Flags: review?(mark.finkle) → review+
tracking-fennec: ? → 28+

Updated

4 years ago
Assignee: nobody → wjohnston
https://hg.mozilla.org/mozilla-central/rev/5e1c5e7785aa
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29

Updated

4 years ago
Status: RESOLVED → VERIFIED
status-firefox29: --- → verified
You need to log in before you can comment on or make changes to this bug.