Closed Bug 956782 Opened 6 years ago Closed 6 years ago

Swap Search and Share in Text-Selection Action Bar

Categories

(Firefox for Android :: General, defect)

ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 29
Tracking Status
firefox29 --- verified
fennec 28+ ---

People

(Reporter: pwd.mozilla, Assigned: wesj)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:29.0) Gecko/20100101 Firefox/29.0 (Beta/Release)
Build ID: 20140103050744

Steps to reproduce:

Search is an inline action where as Share takes you out of the app, thus Search should be grouped with the rest of the inline actions while Share should be moved to the end of the row.
Blocks: 952112, 768667
OS: Linux → Android
Hardware: x86 → ARM
Agreed!
tracking-fennec: --- → ?
Ian, what do you want to do here?
Flags: needinfo?(ibarlow)
I am fine to switch them
Flags: needinfo?(ibarlow)
During triage Wes mentioned he has a patch somewhere with this I think
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(wjohnston)
Attached patch Patch v1Splinter Review
This puts a pretty explicit order in here. Hard to edit later, but nice to be explicit. We can do something easier if you want (i.e. just change the search action).
Attachment #8360633 - Flags: review?(mark.finkle)
Flags: needinfo?(wjohnston)
Attachment #8360633 - Flags: review?(mark.finkle) → review+
tracking-fennec: ? → 28+
Assignee: nobody → wjohnston
https://hg.mozilla.org/mozilla-central/rev/5e1c5e7785aa
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.