956786 - APZ: double tapping on a button will zoom in dialer

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

STR
1. set APZ on
2. launch dialer
3. double tap a key

Expected: no zoom
Actual: you zoom in.

Note:
Gaia      9a222ac02db176e47299bb37112ae40aeadbeca7
Gecko     http://hg.mozilla.org/mozilla-central/rev/14ac61461f2a
BuildID   20140106040201
Version   29.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013
Buri

Comment 1

[Milan Sreckovic [:milan] (needinfo for best results)]

I think this may be a (recent) regression.  Didn't we change how we handle double tap in the past few weeks?

Comment 2

[Kartikaya Gupta (email:[e-mail])]

If you're thinking of bug 941995 then nothing has happened there yet. The dialer app still has a user-scalable=no tag AFAICT so the code in AsyncPanZoomController::ZoomToRect should be preventing any zoom from taking place. It sounds like the zoom constraints are getting dropped or not applied properly, resulting in that code not having the right effect.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

I'm unable to reproduce this on a Peak running master.

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

ya that might be the case.  I can't repro this on today's build... Just going to mark it works for me

Gaia      b7a7191f761933fd4878227488c75d09f5ba890c
Gecko     http://hg.mozilla.org/mozilla-central/rev/cf2d1bd796ea
BuildID   20140108040200
Version   29.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013
Buri

Comment 5

[Natalya Kot [:nkot]]

Attachment: screenshot

I hit this issue using 01/13 master build after turned on/off airplane mode and then launched Dialer... but cannot reproduce it anymore. Will reopen the bug once define some valid STR.

Device: Buri v1.4 (master) Mozilla RIL
BuildID: 20140113040202
Gaia: fd3b9a97cb3c41cfa56be387b46a51db136b4422
Gecko: 12d3ba62a599
Version: 29.0a1
Firmware Version: V1.2-device.cfg