956828 - Change logic for keyboard.is_displayed due to Marionette bug

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Bob Silverberg [:bsilverberg]]

This is a fix to get around Bug #956761

is_displayed is not reporting correctly for the keyboard frame, so instead we are checking for the absence of the 'hide' class.

Note that this is just a workaround fix for the Keyboard app in gaiatest, but does not remove the need to address Bug #956761

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Workaround for for Keyboard.is_displayed()

Comment 3

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8356209 [details] [review]
Workaround for for Keyboard.is_displayed()

The patch seemed good locally, but both Travis and the adhoc run on Jenkins encountered problems, so I'll see if I can figure out how to address the issues found.

Comment 4

[Bob Silverberg [:bsilverberg]]

Attachment: Patch for Keyboard.is_displayed()

Comment 5

[[:AndreiH]]

Comment on attachment 8356383 [details] [review]
Patch for Keyboard.is_displayed()

Comments in PR

Comment 6

[Viorela Ioia [:viorela]]

Comment on attachment 8356383 [details] [review]
Patch for Keyboard.is_displayed()

See comment in PR

Comment 7

[Trif Andrei-Alin[:AlinT]]

Comment on attachment 8356383 [details] [review]
Patch for Keyboard.is_displayed()

the test fails at https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/settings/test_settings_change_keyboard_language.py#L36

Comment 8

[Zac C (:zac)]

I've just xfailed this test while we work on this resolution.

We can re-enable it with this bug.

Comment 9

[Bob Silverberg [:bsilverberg]]

This patch had issues, and the fix is no longer needed. Marking as wontfix.