956833 - Clear manifests cache on memory pressure

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[[:fabrice] Fabrice Desré]

We don't clear the manifests cache (in parent and the wrapped ones in child process) when the memory-pressure observer is fired. Let's do it.

Comment 1

[[:fabrice] Fabrice Desré]

Attachment: mem-pressure-webapps.patch

Memory usage before this patch:

                       |     megabytes     |
      NAME   PID  PPID CPU(s) NICE  USS  PSS  RSS VSIZE OOM_ADJ USER     
       b2g 24862   151   12.5    0 37.5 40.3 47.2 147.8       0 root     
    (Nuwa) 24901 24862    1.0    1  4.0  6.7 13.2  50.0       2 root     
     Usage 24933 24901    1.6   18  6.5 10.8 20.7  61.1      10 app_24933
Homescreen 24949 24901    2.6   18  9.7 14.1 24.0  64.1       8 app_24949

System memory info:

            Total 103.1 MB
     Used - cache  80.0 MB
  B2G procs (PSS)  71.9 MB
    Non-B2G procs   8.1 MB
     Free + cache  23.1 MB
             Free   9.0 MB
            Cache  14.1 MB

Low-memory killer parameters:

  notify_trigger 14336 KB

  oom_adj min_free
        0  4096 KB
        1  5120 KB
        2  6144 KB
        6  7168 KB
        8  8192 KB
       10 20480 KB

And after this patch, once memory-pressure has kicked in.

                       |     megabytes     |
      NAME   PID  PPID CPU(s) NICE  USS  PSS  RSS VSIZE OOM_ADJ USER     
       b2g 24630   151   19.1    0 33.5 35.5 39.7 143.5       0 root     
    (Nuwa) 24672 24630    1.2    1  0.9  2.4  6.2  50.0       2 root     
     Usage 24718 24672    1.8   18  6.5  8.9 14.2  61.1      10 app_24718
Homescreen 24734 24672    4.3   18 13.5 16.5 22.6  70.9       8 app_24734

System memory info:

            Total 103.1 MB
     Used - cache  74.2 MB
  B2G procs (PSS)  63.3 MB
    Non-B2G procs  10.9 MB
     Free + cache  28.9 MB
             Free   2.4 MB
            Cache  26.5 MB

Low-memory killer parameters:

  notify_trigger 14336 KB

  oom_adj min_free
        0  4096 KB
        1  5120 KB
        2  6144 KB
        6  7168 KB
        8  8192 KB
       10 20480 KB

big wins!

Comment 2

[Andreas Gal :gal]

Comment on attachment 8356213 [details] [diff] [review]
mem-pressure-webapps.patch

Ship it!

Comment 3

[Andreas Gal :gal]

We should uplift this to 1.3

Comment 4

[Andreas Gal :gal]

Credit goes to njn for finding this.

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/6a64e79a46e2

Comment 6

[Nicholas Nethercote [inactive]]

> Credit goes to njn for finding this.

It does? Cool! :)

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6a64e79a46e2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4b45e4f20261

Comment 9

[Joe Cheng [:jcheng] (please needinfo)]

status-b2g-v1.3T indicated it's in tarako, remove [tarako]