Closed Bug 956900 Opened 6 years ago Closed 6 years ago

Text-selection action-bar persists after a paste and adding a search engine operation; operation not treated as final

Categories

(Firefox for Android :: Text Selection, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 29
Tracking Status
firefox27 --- unaffected
firefox28 --- affected
firefox29 --- affected
fennec 28+ ---

People

(Reporter: aaronmt, Assigned: wesj)

References

()

Details

(Whiteboard: parity=chrome)

Attachments

(1 file)

Currently we persist visibility of the text-selection action-bar after a paste operation. Editing focus remains.

Steps

i) data:text/html,<textarea>
ii) focus the field and input text 
iii) long-tap, select-all and cut
iv) tap the clipboard button

Expected: Text-selection action-bar visibility is hidden, focus remains in the text-area (blinking cursor), but not editing mode
 
Actual: Text-selection action-bar visibility remains visible, editing focus remains in the text-area

Paste should be treated as a final operation, and I shouldn't need to hit back twice to close the keyboard and drop focus.

--
Nightly (01/06)
Aurora (01/06)
Ian, what do you want to do here?
Flags: needinfo?(ibarlow)
Summary: Text-selection action-bar persists after a paste operation; operation not treated as final → Text-selection action-bar persists after a paste and adding a search engine operation; operation not treated as final
(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #1)
> Ian, what do you want to do here?

The thing that Aaron described. Paste the content and close the action bar in one shot.
Flags: needinfo?(ibarlow)
Thank you, Ian. Mfinkle, who can take this?
Flags: needinfo?(mark.finkle)
Wes is looking into it
Assignee: nobody → wjohnston
Flags: needinfo?(mark.finkle)
Attached patch PatchSplinter Review
Attachment #8363978 - Flags: review?(margaret.leibovic)
Comment on attachment 8363978 [details] [diff] [review]
Patch

Review of attachment 8363978 [details] [diff] [review]:
-----------------------------------------------------------------

Well that was easy :)
Attachment #8363978 - Flags: review?(margaret.leibovic) → review+
tracking-fennec: ? → 28+
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1eb1da4255b5
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
See Also: → 1056144
You need to log in before you can comment on or make changes to this bug.