957010 - LinkedIn "People You May Know" page does not work with mouse when touch events are enabled

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect)

Description

[Marco Mucci [:MarcoM]]

+++ This bug was initially created as a clone of Bug #952831 +++

+++ This bug is concerned with investigating the issue to provide a course of action and recommended point estimate +++

While dogfooding metro mode on win8 desktop I noticed that the LinkedIn "People You May Know" page does not seem to work correctly.  Dynamic content like clicking on the "+Connect" button for a user or trying to expand shared connections does not seem to work.

Comment 1

[Sam Foster [:sfoster] (he/him)]

I can't reproduce any problems here, the +Connect button on the "People You May Know" page works just fine (oops!) as do all the menus and other buttons/links I tried. The shared contacts panel on a persons profile loaded and rendered fine. 

Are you still able to reproduce this Marco?

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

I think I was the original author for bug 952831.  I just retested on my windows 8.1 desktop with 29.0a1 (2014-01-09).

Clicking the +Connect button with dismiss the persons card from the "People You May Know" page, but on other clients it shows an update about a request being sent.  I don't see that update.

Also, the text on the persons card in "People You May Know" (not on their profile) saying something like "2 Shared Connections" should be clickable and expand a set of images showing their profile pictures, etc.  That doesn't seem to work at all.

Are you on a desktop or tablet?  Can you expand the shared connections text within a card on "People You May Know"?  Thanks!

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Screenshot - connect on LinkedIn from People You May Know card

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: Screenshot - expand shared connections on LinkedIn from People You May Know card

This and the previous screenshot show both issues working as expected for me, in fresh build from mozilla-central. Could have been fixed by Bug 957490 or  Bug 945438?

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Hmm.  I just tested with Nightly 29.0a1 (2014-01-10) and I still see the problem about viewing shared connections.  I think this should include those bugs, correct?

I see instead the URL bar appear and reload the page with this address:

  https://www.linkedin.com/people/pymk?trk=nmp-pymk-new_pymk#

Again, I'm on a desktop in windows 8.1 here.

Comment 6

[Matt Brubeck (:mbrubeck)]

This seems to be a mouse-only bug.  When I tap the +Connect or "Compose Message" button with a touch screen, it works correctly.  But when I use a mouse or trackpad, I can reproduce the bug.

This is very similar to bug 945438, but I can still reproduce that problem in a trunk build that includes the fixes for bug 945438 and bug 957490.

Comment 7

[Sam Foster [:sfoster] (he/him)]

Ok, so I can reliably reproduce the problem: in Nightly/Metro the "compose" buttons on the pages function with a tap, but not with a click. Both work fine in Nightly/Desktop. 

With a little debugging/logging, I can see that in the metro case, the tap event gets the <a> as the target on the event, but the mouse click gets a <span> child element as its target and bypasses the intended code path entirely. 
With all the code minification and use of compiled js templates I've not yet found that entry point where the events are registered. Presumably there's some event delegation going on and the event target is failing some test (it has no class info on it). 
I have no insight yet as to why this works as expected in Desktop but not in Metro, why tap but not mouse click. I'll keep looking

Comment 8

[Sam Foster [:sfoster] (he/him)]

Attachment: Debug files and logging output

I'm attaching what I have so far. In the zip are dumps of the events that are fired when clicking one of the "compose" buttons on this page, using finger (tap), using mouse, with mouse.radius.enabled on and off. 
Also in there is a Charles proxy settings file I was using to debug this (http://www.charlesproxy.com/) I used remote mapping to load pretty-printed version of a couple of the js files, and added in an function to dump out diff-able event logs. Those files are in there too - if you import the settings file, you'll see I was loading them off localhost:3000/linkedin/*

Having got the events logged out, I'm not much the wiser. For some reason mouse clicks bypass the code path that is supposed to show the textarea for composing the message. I'd guess there's some logic in there probably using event delegation and some selector that determines which events get handled which way. But the page uses compiled templates (dust.js) and YUI2 and its time consuming attempting to trace it all out. 

I suggest unless other bugs yield insights - or the attached logs have hidden insghts for someone else, that we move this to and evangelism bug and contact LinkedIn. And that we move this to non-blocking.

Comment 9

[Sam Foster [:sfoster] (he/him)]

Other possible next steps - attempt to reproduce using YUI2 samples and dust.js samples - in case this is boilerplate code that might provide a simpler test case - and also tell us more about how widespread the problem might be.

Comment 10

[Matt Brubeck (:mbrubeck)]

This appears to be a bug in LinkedIn that is not Metro Firefox specific.  I can also reproduce it in Chrome when running on a Windows touch-screen PC, or in desktop Firefox with dom.w3c_touch_events.enabled = 1.

Comment 11

[Karl Dubost💡 :karlcow]

This seems to be working now.