Closed Bug 957019 Opened 12 years ago Closed 12 years ago

Don't check cursor position in nsWindow::DealWithPopups() for non-mouse events

Categories

(Core :: Widget: Win32, defect)

x86_64
Windows 8.1
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: masayuki, Assigned: masayuki)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

See bug 953146 comment 37 and bug 953146 comment 41. It doesn't make sense to check mouse cursor position at handling non-mouse messages.
For example: 1. Open dropdown of <select> element 2. Move mouse cursor over the dropdown 3. Press Alt+Space Then, window menu is open but the dropdown isn't closed.
Version: unspecified → Trunk
Attached patch PatchSplinter Review
WM_MOUSEACTIVATE: We need to check the cursor position in this case. I.e., just removing my wrong XXX comment. WM_KILLFOCUS, WM_MOVING, WM_SIZING and WM_MENUSELECT: It doesn't make sense to check mouse cursor position at these events. At this time, all popups should be closed. WM_ACTIVATE (the first chunk of this patch): It doesn't make sense to check mouse cursor position at this event too. However, if active window is changed from/to popup, it must be caused by strange mouse driver or something. I.e., it's unexpected case. So, in such cases, we shouldn't rollup any popups by this event.
Attachment #8357003 - Flags: review?(jmathies)
Attachment #8357003 - Flags: review?(enndeakin)
Attachment #8357003 - Flags: review?(enndeakin) → review+
Attachment #8357003 - Flags: review?(jmathies) → review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Depends on: 1008723
Depends on: 1255020
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: