957019 - Don't check cursor position in nsWindow::DealWithPopups() for non-mouse events

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

See bug 953146 comment 37 and bug 953146 comment 41.

It doesn't make sense to check mouse cursor position at handling non-mouse messages.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

For example:

1. Open dropdown of <select> element
2. Move mouse cursor over the dropdown
3. Press Alt+Space

Then, window menu is open but the dropdown isn't closed.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

WM_MOUSEACTIVATE: We need to check the cursor position in this case. I.e., just removing my wrong XXX comment.

WM_KILLFOCUS, WM_MOVING, WM_SIZING and WM_MENUSELECT: It doesn't make sense to check mouse cursor position at these events. At this time, all popups should be closed.

WM_ACTIVATE (the first chunk of this patch): It doesn't make sense to check mouse cursor position at this event too. However, if active window is changed from/to popup, it must be caused by strange mouse driver or something. I.e., it's unexpected case. So, in such cases, we shouldn't rollup any popups by this event.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/79595e16949f

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/79595e16949f